Skip to content

net: tcp: net_tcp_queue_pkt: Lock while appending to sent_list #9819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

net: tcp: net_tcp_queue_pkt: Lock while appending to sent_list #9819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions subsys/net/ip/tcp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,7 +846,14 @@ int net_tcp_queue_data(struct net_context *context, struct net_pkt *pkt)
*/
static int net_tcp_queue_pkt(struct net_context *context, struct net_pkt *pkt)
{
unsigned int key;

/* slist is not thread-safe, can be interrupted by retry timer and
* accessed concurrently, protect against that.
*/
key = irq_lock();
sys_slist_append(&context->tcp->sent_list, &pkt->sent_list);
irq_unlock(key);

/* We need to restart retry_timer if it is stopped. */
if (k_delayed_work_remaining_get(&context->tcp->retry_timer) == 0) {
Expand Down