Skip to content

drivers: i2s: stm32 sai add support for stm32f4xx series #97829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2025
Merged

drivers: i2s: stm32 sai add support for stm32f4xx series #97829

merged 3 commits into from
Oct 22, 2025

Conversation

@mariopaja
Copy link
Contributor

@mariopaja mariopaja commented Oct 17, 2025 •
edited
Loading

This PR enables SAI on STM32F4xx series by:

  1. Adding SAI1 A/B nodes
  2. Update DMA configurations for STM32F4xx
  3. Adding nucleo_f429zi in samples/drivers/i2s/output
stm32f4xx_sai

Audio Test:
2CH, 16bit, 44.1KHz, PCM5102a

stm32f4xx_sai.mp4

@mariopaja mariopaja mentioned this pull request Oct 17, 2025
Open
21 tasks
@mariopaja
dts: st: f4: enable sai1 in stm32f4xx series
91e791b 
These changes enable SAI1 A & B nodes in STM32F4xx series.

Signed-off-by: Mario Paja <[email protected]>
@mariopaja
drivers: i2s: stm32 sai add support for stm32f4xx series
84abd2e 
STM32F4xx series shares several DMA configurations with
the other platforms. These changes aim to enable platform
specific DMA configuration and align them to other platforms.

Signed-off-by: Mario Paja <[email protected]>
@mariopaja
samples: i2s: output: add nucleo_f429zi
cc72746 
Add nucleo_f429zi board in samples/drivers/i2s/output

Signed-off-by: Mario Paja <[email protected]>
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@mariopaja mariopaja marked this pull request as ready for review October 19, 2025 10:33
@erwango erwango added this to the v4.3.0 milestone Oct 20, 2025
@anangl anangl removed their assignment Oct 20, 2025
gautierg-st
gautierg-st reviewed Oct 20, 2025
View reviewed changes
Copy link
Contributor

@gautierg-st gautierg-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have several suggestions to replace the CONFIG_SOC_SERIES_XXX macros. I think it would ease the porting of other series featuring the SAI, and would also lighten the code a bit.

drivers/i2s/i2s_stm32_sai.c
Comment on lines 320 to +322
#if !defined(CONFIG_SOC_SERIES_STM32H7X) && !defined(CONFIG_SOC_SERIES_STM32L4X) && \
!defined(CONFIG_SOC_SERIES_STM32G4X) && !defined(CONFIG_SOC_SERIES_STM32L5X)
!defined(CONFIG_SOC_SERIES_STM32G4X) && !defined(CONFIG_SOC_SERIES_STM32L5X) && \
!defined(CONFIG_SOC_SERIES_STM32F4X)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we replace all these defined with a single #if DT_HAS_COMPAT_STATUS_OKAY(st_stm32u5_dma) ?
That would probably make adding other series easier.

Copy link
Contributor Author

@mariopaja mariopaja Oct 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do it on a separate PR after F7 is merged (and then I am node with almost all series), It is already in todo :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well. Approved!

drivers/i2s/i2s_stm32_sai.c
Comment on lines 331 to +333
#if !defined(CONFIG_SOC_SERIES_STM32H7X) && !defined(CONFIG_SOC_SERIES_STM32L4X) && \
!defined(CONFIG_SOC_SERIES_STM32G4X) && !defined(CONFIG_SOC_SERIES_STM32L5X)
!defined(CONFIG_SOC_SERIES_STM32G4X) && !defined(CONFIG_SOC_SERIES_STM32L5X) && \
!defined(CONFIG_SOC_SERIES_STM32F4X)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

drivers/i2s/i2s_stm32_sai.c
Comment on lines 352 to +354
#elif !defined(CONFIG_SOC_SERIES_STM32H7X) && !defined(CONFIG_SOC_SERIES_STM32L4X) && \
!defined(CONFIG_SOC_SERIES_STM32G4X) && !defined(CONFIG_SOC_SERIES_STM32L5X)
!defined(CONFIG_SOC_SERIES_STM32G4X) && !defined(CONFIG_SOC_SERIES_STM32L5X) && \
!defined(CONFIG_SOC_SERIES_STM32F4X)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

drivers/i2s/i2s_stm32_sai.c
Comment on lines 293 to +295
#if defined(CONFIG_SOC_SERIES_STM32H7X) || defined(CONFIG_SOC_SERIES_STM32L4X) || \
defined(CONFIG_SOC_SERIES_STM32G4X) || defined(CONFIG_SOC_SERIES_STM32L5X)
defined(CONFIG_SOC_SERIES_STM32G4X) || defined(CONFIG_SOC_SERIES_STM32L5X) || \
defined(CONFIG_SOC_SERIES_STM32F4X)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here we could maybe use #if DT_HAS_COMPAT_STATUS_OKAY(st_stm32_dma_v1) || DT_HAS_COMPAT_STATUS_OKAY(st_stm32_dma_v2) ?

drivers/i2s/i2s_stm32_sai.c
Comment on lines 469 to +470
/* Control of MCLK output from SAI configuration is not possible on STM32L4xx MCUs */
#if !defined(CONFIG_SOC_SERIES_STM32L4X)
#if !defined(CONFIG_SOC_SERIES_STM32L4X) && !defined(CONFIG_SOC_SERIES_STM32F4X)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is outdated (missing F4). This could be replaced with #ifdef SAI_MCK_OUTPUT_ENABLE to avoid having to add other series in future.

drivers/i2s/i2s_stm32_sai.c
}

hdma->Instance = STM32_DMA_GET_INSTANCE(stream->reg, stream->dma_channel);
#if defined(CONFIG_SOC_SERIES_STM32F4X)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it could probably be #ifdef DMA_CHANNEL_1.

drivers/i2s/i2s_stm32_sai.c
#endif

#if defined(CONFIG_SOC_SERIES_STM32H7X)
#if defined(CONFIG_SOC_SERIES_STM32H7X) || defined(CONFIG_SOC_SERIES_STM32F4X)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here #ifdef DMA_FIFOMODE_DISABLE

drivers/i2s/i2s_stm32_sai.c
Comment on lines 483 to +484
/* MckOverSampling is not supported by all STM32L4xx MCUs */
#if !defined(CONFIG_SOC_SERIES_STM32L4X)
#if !defined(CONFIG_SOC_SERIES_STM32L4X) && !defined(CONFIG_SOC_SERIES_STM32F4X)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Could be replaced with #ifdef SAI_MCK_OVERSAMPLING_DISABLE

@kartben kartben merged commit e3005ec into zephyrproject-rtos:main Oct 22, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gautierg-st gautierg-st gautierg-st approved these changes

@erwango erwango erwango approved these changes

@anangl anangl Awaiting requested review from anangl

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@etienne-lms etienne-lms Awaiting requested review from etienne-lms

@FRASTM FRASTM Awaiting requested review from FRASTM

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@JarmouniA JarmouniA Awaiting requested review from JarmouniA

@kartben kartben Awaiting requested review from kartben

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

@nashif nashif Awaiting requested review from nashif

@TomasBarakNXP TomasBarakNXP Awaiting requested review from TomasBarakNXP

Assignees

@erwango erwango

Labels

area: Boards/SoCs area: I2S area: Samples Samples platform: STM32 ST Micro STM32

Projects

None yet

Milestone

v4.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@mariopaja @erwango @gautierg-st @kartben @anangl @zephyrbot