stm32wba : ble-802.15.4 concurrent mode integration #97773

vtardy-st · 2025-10-17T08:13:38Z

Integration of the BLE-802.15.4 concurrent mode on stm32wba based on CubeWBA release 1.7.0
Add new sample application ble-802.15.4 echo_client concurrent mode

github-actions · 2025-10-17T08:17:31Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_stm32	zephyrproject-rtos/hal_stm32@`55e1597`	zephyrproject-rtos/hal_stm32#319	zephyrproject-rtos/hal_stm32#319/files

Additional metadata changed:

Name	URL	Submodules	West cmds	`module.yml`	Blobs
hal_stm32				✏	2x 🆕

⛔ DNM label due to: 1 project with PR revision, 1 project with metadata changes and 2 blob changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

etienne-lms

For commit "soc: stm32: add parameter in link_layer_register_isr() function", suggested commit header line:

-soc: stm32: add parameter in link_layer_register_isr() function
+soc: st: stm32wba: hci_if: allow forcing ISR registration

I think the 3 first commits should be squashed unless what build would fail on the 1st commit and on the 2nd commits. Suggestion commit message:

soc: st: stm32wba: hci_if: allow forcing ISR registration

Add parameter to the link_layer_register_isr() ...

Update Bluetooth hci_stm32wba.c and IEEE 802.15.4 ieee802154_stm32wba.c
drivers accordingly.

Signed-off-by: ...

Can the west manifest be updated independently (in a specific commit), or is it needed regarding changes in the 3 first commits?

etienne-lms · 2025-10-30T10:10:57Z

soc/st/stm32/stm32wbax/hci_if/linklayer_plat_adapt.c



-void link_layer_register_isr(void)
+void link_layer_register_isr(uint8_t force)


Maybe use bool instead for force and is_isr_registered.

force parameter and is_isr_registered variable types have been modified to 'bool' type

etienne-lms · 2025-10-30T10:24:10Z

samples/boards/st/ble_802154/ble_hr_802154_echo_client/Kconfig

@@ -0,0 +1,61 @@
+# Private config options for ble HR - Networking echo-client sample app
+
+# Copyright (c) 2018 Intel Corporation


Also add ST copyright since you also modify the content you initially started from.

ST copyright has been added in modified files coming from an existing copyrighted implementation

etienne-lms · 2025-10-30T10:24:24Z

samples/boards/st/ble_802154/ble_hr_802154_echo_client/Kconfig

+# Copyright (c) 2018 Intel Corporation
+# SPDX-License-Identifier: Apache-2.0
+
+mainmenu "Ble Heart Rate - Networking echo-client sample application"


Suggested change

mainmenu "Ble Heart Rate - Networking echo-client sample application"

mainmenu "BLE Heart Rate - Networking echo-client sample application"

change done

etienne-lms · 2025-10-30T10:28:50Z

samples/boards/st/ble_802154/ble_hr_802154_echo_client/README.rst

@@ -0,0 +1,68 @@
+.. zephyr:code-sample:: stm32_ble_hr_802154_echo_client
+   :name: Ble HR - 802154 Echo client (advanced)


Suggested change

:name: Ble HR - 802154 Echo client (advanced)

:name: BLE HR - 802154 Echo client (advanced)

change done

etienne-lms · 2025-10-30T10:29:29Z

samples/boards/st/ble_802154/ble_hr_802154_echo_client/README.rst

+.. zephyr:code-sample:: stm32_ble_hr_802154_echo_client
+   :name: Ble HR - 802154 Echo client (advanced)
+
+   Implement a Bluetooth Heart Rate - 802154 client.


Suggested change

Implement a Bluetooth Heart Rate - 802154 client.

Implement a Bluetooth |reg| Heart Rate - 802154 client.

change done

etienne-lms · 2025-10-30T10:39:35Z

samples/boards/st/ble_802154/ble_hr_802154_echo_client/sample.yaml

+  description: Test concurrent mode Ble HeartRate - IEEE802.15.4 echo client
+  name: Ble Heart Rate - Socket Echo Client


Suggested change

description: Test concurrent mode Ble HeartRate - IEEE802.15.4 echo client

name: Ble Heart Rate - Socket Echo Client

description: Test concurrent mode BLE Heart Rate - IEEE802.15.4 echo client

name: BLE Heart Rate - Socket Echo Client

change done

etienne-lms · 2025-10-30T10:43:10Z

samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/app_ble.c

+
+/*
+ * Copyright (c) 2024 Nordic Semiconductor ASA
+ * Copyright (c) 2015-2016 Intel Corporation


For all these source file, are they raw dump of existing implementation or did you start from an existing copyrighted implementation you modified. In the latter case, I think you should also add ST copyright.

app_ble.c is heritated from main.c of bluetooth peripheral hr and includes some ST changes.
ST copyright has been added and other copyrights have been kept

etienne-lms · 2025-10-30T10:43:30Z

samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/app_ble.c

+
+#include "common.h"
+
+static bool hrf_ntf_enabled;


Could you add an empty line below?

change done

etienne-lms · 2025-10-30T10:43:55Z

samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/app_ble.c

+static bool hrf_ntf_enabled;
+#if defined(CONFIG_BT)
+static const struct bt_data ad[] = {
+	BT_DATA_BYTES(BT_DATA_FLAGS, (BT_LE_AD_GENERAL | BT_LE_AD_NO_BREDR)),


Suggested change

BT_DATA_BYTES(BT_DATA_FLAGS, (BT_LE_AD_GENERAL | BT_LE_AD_NO_BREDR)),

BT_DATA_BYTES(BT_DATA_FLAGS, BT_LE_AD_GENERAL | BT_LE_AD_NO_BREDR),

change done

etienne-lms · 2025-10-30T10:46:03Z

samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/app_ble.c

+#define BLINK_ONOFF K_MSEC(500)
+
+static struct k_work_delayable blink_work;
+static bool                  led_is_on;


Prefer without inner indentation?

change done

Add parameter to the link_layer_register_isr() to force or not the link layer isr registration in case of multiple function calls Update Bluetooth hci_stm32wba.c driver and IEEE 802.15.4 ieee802154_stm32wba.c driver accordingly. Signed-off-by: Vincent Tardy <[email protected]>

Integration of the BLE-802.15.4 concurrent mode on stm32wba. Signed-off-by: Vincent Tardy <[email protected]>

vtardy-st · 2025-10-30T16:44:15Z

For commit "soc: stm32: add parameter in link_layer_register_isr() function", suggested commit header line:
-soc: stm32: add parameter in link_layer_register_isr() function
+soc: st: stm32wba: hci_if: allow forcing ISR registration
I think the 3 first commits should be squashed unless what build would fail on the 1st commit and on the 2nd commits. Suggestion commit message:
soc: st: stm32wba: hci_if: allow forcing ISR registration

Add parameter to the link_layer_register_isr() ...

Update Bluetooth hci_stm32wba.c and IEEE 802.15.4 ieee802154_stm32wba.c
drivers accordingly.

Signed-off-by: ...
Can the west manifest be updated independently (in a specific commit), or is it needed regarding changes in the 3 first commits?

The first three commits have been squashed as suggested

etienne-lms

Some of the sonarqubecloud reports are worth to be addressed IMHO. See the few comments below.

etienne-lms · 2025-10-31T10:45:19Z

samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/tcp.c

+	if (ret < 0) {
+		LOG_ERR("Failed to set TLS_SEC_TAG_LIST option (%s): %d",
+			data->proto, errno);
+		ret = -errno;


As noticed by sonarqubecloud, error here is discarded. return ret seems missing.

Not sure that the fact that 'set TLS_SEC_TAG_LIST option' fails is critical:
If yes, I agree 'return ret' seems missing.
Else, we could just remove 'ret = -errno;'

etienne-lms · 2025-10-31T10:51:19Z

samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/udp.c

+{
+	/* This means that we did not receive response in time. */
+	struct udp_control *ctrl = CONTAINER_OF(timer, struct udp_control, rx_timer);
+	struct sample_data *data = (ctrl == conf.ipv4.udp.ctrl) ? &conf.ipv4 : &conf.ipv6;


Suggested change

struct sample_data *data = (ctrl == conf.ipv4.udp.ctrl) ? &conf.ipv4 : &conf.ipv6;

struct sample_data __maybe_unused *data = (ctrl == conf.ipv4.udp.ctrl) ? &conf.ipv4 : &conf.ipv6;

etienne-lms · 2025-10-31T10:52:01Z

samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/udp.c

+	if (ret < 0) {
+		LOG_ERR("Failed to set TLS_SEC_TAG_LIST option (%s): %d",
+			data->proto, errno);
+		ret = -errno;


return -errno;?
Ditto at line 232?

Add sample Bluetooth Heart Rate - 802154 Echo Client Signed-off-by: Vincent Tardy <[email protected]>

sonarqubecloud · 2025-10-31T14:00:45Z

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
76.9% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added platform: STM32 ST Micro STM32 area: Boards/SoCs area: IEEE 802.15.4 area: Samples Samples area: Bluetooth HCI Bluetooth HCI Driver area: Bluetooth labels Oct 17, 2025

zephyrbot requested review from FRASTM, GeorgeCGV, HoZHel, Thalley, alwa-nordic, asm5878, benothmn-st, djiatsaf-st, erwango, etienne-lms, gautierg-st, hermabe, jhedberg, marwaiehm-st and mathieuchopstm October 17, 2025 08:15

zephyrbot assigned erwango Oct 17, 2025

github-actions bot added manifest manifest-hal_stm32 DNM (manifest) This PR should not be merged (controlled by action-manifest) Binary Blobs Added labels Oct 17, 2025

hermabe removed their request for review October 17, 2025 08:23

vtardy-st marked this pull request as draft October 17, 2025 09:33

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 37cc906 to 17625f4 Compare October 17, 2025 10:02

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 17625f4 to 6bb9f3c Compare October 17, 2025 13:56

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 6bb9f3c to 1c54b5e Compare October 30, 2025 09:21

etienne-lms reviewed Oct 30, 2025

View reviewed changes

vtardy-st added 2 commits October 30, 2025 16:03

manifest: update hal_stm32 to support ble-ieee802152 concurrent mode

dc777e3

Integration of the BLE-802.15.4 concurrent mode on stm32wba. Signed-off-by: Vincent Tardy <[email protected]>

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 1c54b5e to 0bf002f Compare October 30, 2025 16:43

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 0bf002f to da83d2c Compare October 30, 2025 16:52

etienne-lms reviewed Oct 31, 2025

View reviewed changes

samples: boards: st: ble ieee802.15.4 concurrent mode

615a0b8

Add sample Bluetooth Heart Rate - 802154 Echo Client Signed-off-by: Vincent Tardy <[email protected]>

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from da83d2c to 615a0b8 Compare October 31, 2025 13:34



		void link_layer_register_isr(void)
		void link_layer_register_isr(uint8_t force)

		@@ -0,0 +1,61 @@
		# Private config options for ble HR - Networking echo-client sample app

		# Copyright (c) 2018 Intel Corporation

	mainmenu "Ble Heart Rate - Networking echo-client sample application"
	mainmenu "BLE Heart Rate - Networking echo-client sample application"

		@@ -0,0 +1,68 @@
		.. zephyr:code-sample:: stm32_ble_hr_802154_echo_client
		:name: Ble HR - 802154 Echo client (advanced)

	Implement a Bluetooth Heart Rate - 802154 client.
	Implement a Bluetooth \|reg\| Heart Rate - 802154 client.

		description: Test concurrent mode Ble HeartRate - IEEE802.15.4 echo client
		name: Ble Heart Rate - Socket Echo Client

	BT_DATA_BYTES(BT_DATA_FLAGS, (BT_LE_AD_GENERAL \| BT_LE_AD_NO_BREDR)),
	BT_DATA_BYTES(BT_DATA_FLAGS, BT_LE_AD_GENERAL \| BT_LE_AD_NO_BREDR),

	struct sample_data *data = (ctrl == conf.ipv4.udp.ctrl) ? &conf.ipv4 : &conf.ipv6;
	struct sample_data __maybe_unused *data = (ctrl == conf.ipv4.udp.ctrl) ? &conf.ipv4 : &conf.ipv6;

stm32wba : ble-802.15.4 concurrent mode integration #97773

Are you sure you want to change the base?

stm32wba : ble-802.15.4 concurrent mode integration #97773

Uh oh!

Conversation

vtardy-st commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

etienne-lms left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vtardy-st commented Oct 30, 2025

Uh oh!

etienne-lms left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 31, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Oct 17, 2025 •

edited

Loading