drivers: video: improve the sample and ESP32 driver #95958
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josuah
force-pushed
the
pr_video_esp32_fix
branch
from
099130a to
e76a0b1
Compare
|
Currently, this still does not work because there was a correction for RGB vs BGR swap in displays in #79996 I applied this fix 099130a And I get this image as a result:
This is a HFLIP and upside-down version of the classic MacBeth color chart: seems ok.
However, I only see the first frame, the display is not updated. |
zephyrbot
added
platform: ESP32
zephyrbot
requested review from
JarmouniA,
LucasTambor,
avolmat-st,
kartben,
loicpoulain,
marekmatej,
nashif,
ngphibang,
raffarost,
sylvioalves,
uLipe and
wmrsouza
|
@josuah, make |
josuah
force-pushed
the
pr_video_esp32_fix
branch
3 times, most recently
from
113e27e to
8ba7e39
Compare
|
I confirm, this works smoothly now. Force-push:
|
sylvioalves
previously approved these changes
Sep 16, 2025
ngphibang
previously approved these changes
Sep 16, 2025
Increase the ESP32 S3 Eye board buffer size to fit the selected frame size configured. This fixes a buffer allocation error preventing the sample to run. Only use a single buffer which is enough to run it. Signed-off-by: Josuah Demangeon <[email protected]>
In the ESP32 video driver, set the caps.min_vbuf_count field to indicate that a two buffers are enough. Fix use of un-initialized memory breaking the samples in some situations. Signed-off-by: Josuah Demangeon <[email protected]>
Propagate zephyrproject-rtos#79996 where RGB_565 and BGR_565 interchange got fixed. It is not necessary to enable the BGR_565 format for the ST7789V display as RGB_565, the default, is correct. Signed-off-by: Josuah Demangeon <[email protected]>
josuah
force-pushed
the
pr_video_esp32_fix
branch
from
8ba7e39 to
71e5694
Compare
|
Good point, this is now only having the ESP32-specific commit... Another review cycle then. |
|
sylvioalves
approved these changes
Sep 16, 2025
ngphibang
approved these changes
Sep 16, 2025
wmrsouza
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small adjustments to make the ESP32 DVP driver work out of the box.
I will test it with the OV2640 present on the ESP32-S3 EYE board as soon as I get a chance (past Monday), and then un-draft the PR.