drivers: gpio: Migrate to new logging subsys #9430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9430 +/- ##
=======================================
Coverage 52.19% 52.19%
=======================================
Files 215 215
Lines 26010 26010
Branches 5594 5594
=======================================
Hits 13576 13576
Misses 10175 10175
Partials 2259 2259Continue to review full report at Codecov.
|
Migrate from `SYS_LOG` to `LOG` logging mechanism. Signed-off-by: Olivier Martin <[email protected]>
Olivier-ProGlove
force-pushed
the
upstream-logging-gpio
branch
from
52e72ec to
e9642e9
Compare
Contributor
Author
|
I have rebased the pull-request to fix the conflict after this pull-request has been merged 8cf8db3 |
nordic-krch
requested changes
Sep 3, 2018
Contributor
nordic-krch
left a comment
nordic-krch
left a comment
There was a problem hiding this comment.
I am missing registration of log module (LOG_MODULE_REGISTER)
| int ret; | ||
|
|
||
| #if (CONFIG_SYS_LOG_GPIO_PCAL9535A_LEVEL >= SYS_LOG_LEVEL_DEBUG) | ||
| #if (CONFIG_LOG_GPIO_LEVEL >= LOG_LEVEL_DEBUG) |
Contributor
There was a problem hiding this comment.
you should be able to remove this #ifdef, compiler will cut it if logs are gone.
Member
|
addressed in #10029 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from
SYS_LOGtoLOGlogging mechanism.Signed-off-by: Olivier Martin [email protected]