Skip to content

Conversation

@Olivier-ProGlove
Copy link
Contributor

Migrate from SYS_LOG to LOG logging mechanism.

Signed-off-by: Olivier Martin [email protected]

@codecov-io
Copy link

codecov-io commented Aug 14, 2018

Codecov Report

Merging #9429 into master will increase coverage by 2.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9429      +/-   ##
==========================================
+ Coverage   52.19%   54.38%   +2.19%     
==========================================
  Files         215      216       +1     
  Lines       26010    29924    +3914     
  Branches     5594     6836    +1242     
==========================================
+ Hits        13576    16275    +2699     
- Misses      10175    11134     +959     
- Partials     2259     2515     +256
Impacted Files Coverage Δ
lib/posix/clock.c 78.57% <0%> (-21.43%) ⬇️
lib/cmsis_rtos_v1/cmsis_kernel.c 91.66% <0%> (-8.34%) ⬇️
subsys/net/ip/tcp_internal.h 48.27% <0%> (-1.73%) ⬇️
include/misc/stack.h 90.9% <0%> (-1.4%) ⬇️
lib/cmsis_rtos_v1/cmsis_thread.c 72.44% <0%> (-1.09%) ⬇️
lib/mempool/mempool.c 95.07% <0%> (-0.55%) ⬇️
subsys/net/ip/rpl.c 13.69% <0%> (-0.5%) ⬇️
include/kernel.h 98.43% <0%> (-0.1%) ⬇️
include/net/socket.h 100% <0%> (ø) ⬆️
include/posix/time.h 100% <0%> (ø) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f7e33...e268af9. Read the comment docs.

Migrate from `SYS_LOG` to `LOG` logging mechanism.

Signed-off-by: Olivier Martin <[email protected]>
@Olivier-ProGlove Olivier-ProGlove force-pushed the upstream-logging-clock-control branch from dbe1a65 to e268af9 Compare August 17, 2018 16:14
@Olivier-ProGlove
Copy link
Contributor Author

I have rebased the pull-request to fix the conflict after this pull-request has been merged 8cf8db3

Copy link
Contributor

@nordic-krch nordic-krch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing LOG_MODULE_REGISTER. Compilation will probably fail when logs are actually enabled in kconfig.

@nashif
Copy link
Member

nashif commented Sep 17, 2018

cherrypicked in #10029

@Olivier-ProGlove
Copy link
Contributor Author

You cherry-pick is broken! Normally when you use git cherry-pick the git commit message is kept.

@nashif
Copy link
Member

nashif commented Oct 8, 2018

addressed in #10029

@nashif nashif closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants