Skip to content

Conversation

@Olivier-ProGlove
Copy link
Contributor

Migrate from SYS_LOG to LOG logging mechanism.

Signed-off-by: Olivier Martin [email protected]

Migrate from `SYS_LOG` to `LOG` logging mechanism.

Signed-off-by: Olivier Martin <[email protected]>
@codecov-io
Copy link

codecov-io commented Aug 14, 2018

Codecov Report

Merging #9427 into master will increase coverage by 0.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9427      +/-   ##
==========================================
+ Coverage   52.17%   53.15%   +0.98%     
==========================================
  Files         212      216       +4     
  Lines       25892    33259    +7367     
  Branches     5561     7840    +2279     
==========================================
+ Hits        13508    17679    +4171     
- Misses      10126    12805    +2679     
- Partials     2258     2775     +517
Impacted Files Coverage Δ
lib/posix/clock.c 78.57% <0%> (-21.43%) ⬇️
subsys/net/ip/tcp_internal.h 48.27% <0%> (-1.73%) ⬇️
include/misc/stack.h 90.9% <0%> (-1.4%) ⬇️
include/net/net_pkt.h 84.87% <0%> (-1.34%) ⬇️
lib/mempool/mempool.c 95.07% <0%> (-0.55%) ⬇️
subsys/net/l2/ethernet/arp.c 53.87% <0%> (-0.19%) ⬇️
include/kernel.h 98.38% <0%> (-0.06%) ⬇️
include/net/socket.h 100% <0%> (ø) ⬆️
include/posix/time.h 100% <0%> (ø) ⬆️
subsys/net/ip/ipv6.h 100% <0%> (ø) ⬆️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b3a7ed...6afbd5b. Read the comment docs.

Copy link
Contributor

@nordic-krch nordic-krch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

the access alignment required by used flash driver.

config SYS_LOG_IMG_MANAGER_LEVEL
config LOG_IMG_MANAGER_LEVEL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I would prefer IMG_MANAGER_LOG_LEVEL.

@nashif nashif added this to the v1.14.0 milestone Sep 6, 2018
@nashif
Copy link
Member

nashif commented Oct 8, 2018

addressed in #10029

@nashif nashif closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants