lib: minimal: Migrate to new logging subsys #9425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate from `SYS_LOG` to `LOG` logging mechanism. Signed-off-by: Olivier Martin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9425 +/- ##
=======================================
Coverage 52.16% 52.16%
=======================================
Files 212 212
Lines 25894 25894
Branches 5563 5563
=======================================
Hits 13507 13507
Misses 10129 10129
Partials 2258 2258Continue to review full report at Codecov.
|
nordic-krch
requested changes
Sep 3, 2018
| #include <misc/mempool.h> | ||
| #include <string.h> | ||
| #include <logging/sys_log.h> | ||
| #include <logging/log.h> |
Contributor
There was a problem hiding this comment.
you are missing LOG_MODULE_NAME definition and LOG_MODULE_REGISTER()
| ARG_UNUSED(size); | ||
|
|
||
| SYS_LOG_DBG("CONFIG_MINIMAL_LIBC_MALLOC_ARENA_SIZE is 0\n"); | ||
| LOG_DBG("CONFIG_MINIMAL_LIBC_MALLOC_ARENA_SIZE is 0\n"); |
Contributor
There was a problem hiding this comment.
you can remove '\n' by default new line is added by the logger.
Member
|
addressed in #10029 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from
SYS_LOGtoLOGlogging mechanism.Signed-off-by: Olivier Martin [email protected]