-
Notifications
You must be signed in to change notification settings - Fork 8.2k
subsys: fs: nvs: Migrate to new logging subsys #9360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subsys: fs: nvs: Migrate to new logging subsys #9360
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9360 +/- ##
==========================================
+ Coverage 52.53% 53.66% +1.12%
==========================================
Files 212 216 +4
Lines 25821 33720 +7899
Branches 5428 7942 +2514
==========================================
+ Hits 13565 18095 +4530
- Misses 10071 12869 +2798
- Partials 2185 2756 +571
Continue to review full report at Codecov.
|
subsys/fs/nvs/nvs_priv.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would move this block to nvs.c next to module registration.
Add:
#define LOG_LEVEL CONFIG_NVS_LOG_LEVEL
To get logging configuration from kconfig.
|
@Olivier-ProGlove Thanks for this effort! |
|
@Olivier-ProGlove Can you rework this PR as PR #8141 was merged. I belief that now the mainline code is almost there. |
Migrate from `SYS_LOG` to `LOG` logging mechanism. Signed-off-by: Olivier Martin <[email protected]>
850d1a0 to
813abea
Compare
|
@nvlsianpu Pull-request rebased |
| #define SYS_LOG_DOMAIN "fs/nvs" | ||
| #define SYS_LOG_LEVEL CONFIG_NVS_LOG_LEVEL | ||
| #include <logging/sys_log.h> | ||
| #include <logging/log.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this include can also be moved to nvs.c. Note that LOG_MODULE_NAME and LOG_LEVEL definition can be provided after log.h include.
|
addressed in #10029 |
Migrate from
SYS_LOGtoLOGlogging mechanism.Signed-off-by: Olivier Martin [email protected]