Skip to content

Conversation

@Olivier-ProGlove
Copy link
Contributor

Migrate from SYS_LOG to LOG logging mechanism.

Signed-off-by: Olivier Martin [email protected]

@codecov-io
Copy link

codecov-io commented Aug 9, 2018

Codecov Report

Merging #9360 into master will increase coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9360      +/-   ##
==========================================
+ Coverage   52.53%   53.66%   +1.12%     
==========================================
  Files         212      216       +4     
  Lines       25821    33720    +7899     
  Branches     5428     7942    +2514     
==========================================
+ Hits        13565    18095    +4530     
- Misses      10071    12869    +2798     
- Partials     2185     2756     +571
Impacted Files Coverage Δ
lib/posix/clock.c 78.57% <0%> (-21.43%) ⬇️
subsys/net/lib/coap/coap_link_format.c 14.74% <0%> (-2.07%) ⬇️
subsys/net/ip/tcp_internal.h 48.27% <0%> (-1.73%) ⬇️
include/net/net_pkt.h 84.14% <0%> (-1.51%) ⬇️
include/misc/stack.h 90.9% <0%> (-1.4%) ⬇️
lib/mempool/mempool.c 95.07% <0%> (-0.55%) ⬇️
include/logging/log_msg.h 81.45% <0%> (-0.37%) ⬇️
subsys/net/ip/icmpv4.c 38.09% <0%> (-0.26%) ⬇️
subsys/net/l2/ethernet/arp.c 53.87% <0%> (-0.19%) ⬇️
include/kernel.h 98.38% <0%> (-0.06%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9d980...813abea. Read the comment docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would move this block to nvs.c next to module registration.
Add:
#define LOG_LEVEL CONFIG_NVS_LOG_LEVEL
To get logging configuration from kconfig.

@nvlsianpu
Copy link
Contributor

@Olivier-ProGlove Thanks for this effort!
@nordic-krch, @carlescufi Is it possible that we first merge #8141 and then replay this PR o that?

@nvlsianpu
Copy link
Contributor

@Olivier-ProGlove Can you rework this PR as PR #8141 was merged. I belief that now the mainline code is almost there.

Migrate from `SYS_LOG` to `LOG` logging mechanism.

Signed-off-by: Olivier Martin <[email protected]>
@Olivier-ProGlove
Copy link
Contributor Author

@nvlsianpu Pull-request rebased
@nordic-krch Comment taken in account

#define SYS_LOG_DOMAIN "fs/nvs"
#define SYS_LOG_LEVEL CONFIG_NVS_LOG_LEVEL
#include <logging/sys_log.h>
#include <logging/log.h>
Copy link
Contributor

@nordic-krch nordic-krch Sep 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this include can also be moved to nvs.c. Note that LOG_MODULE_NAME and LOG_LEVEL definition can be provided after log.h include.

@nashif
Copy link
Member

nashif commented Oct 8, 2018

addressed in #10029

@nashif nashif closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants