drivers: sensor: bma4xx: Avoid potential overflow #92496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Sensors
github-actions
bot
requested review from
MaureenHelm,
asemjonovs,
avisconti,
jeppenodgaard,
teburd,
tristan-google,
ubieda and
yperess
MaureenHelm
previously approved these changes
Jul 2, 2025
SpinFast
approved these changes
Jul 2, 2025
kartben
reviewed
Jul 3, 2025
Coverity reports a potential integer overflow in the accel_range computation due to the use of a left shift on an int type. CID 520269: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) Even though the register value is constrained to 0–3 by the BMA456 spec, and no real overflow occurs, an explicit cast to int64_t prevents false positives and aligns with safe coding practices. Fixes: zephyrproject-rtos#90517 Signed-off-by: Gaetan Perrot <[email protected]>
moonlight83340
force-pushed
the
Coverity_CID_520269
branch
from
adfe600 to
98f8b54
Compare
kartben
approved these changes
Jul 3, 2025
|
MaureenHelm
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity reports a potential integer overflow in the accel_range computation due to the use of a left shift on an int type.
CID 520269: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)
Even though the register value is constrained to 0–3 by the BMA456 spec, and no real overflow occurs, an explicit cast to int64_t prevents false positives and aligns with safe coding practices.
Fixes: #90517