boards: waveshare: rp2040_plus: add 16M flash board #92384
Conversation
| - name: rp2040 | ||
| variants: | ||
| - name: "16m" |
There was a problem hiding this comment.
this is not a board variant, this is a board revision, switch to board revision
There was a problem hiding this comment.
Why is this a revision, not a variant? https://docs.zephyrproject.org/latest/hardware/porting/board_porting.html#multiple-board-revisions seems very geared to what I think of as a revision, e.g "Revision A" "1.2.3" .
It feels very variant-y to me, what am I missing here?
There was a problem hiding this comment.
As per https://docs.zephyrproject.org/latest/glossary.html#term-variant and https://docs.zephyrproject.org/latest/glossary.html#term-board-revision variant is for a different configuration of the same hardware so if you can run code from RAM or flash or external flash which are all on a dev board then they would be variants but if you need a different board entirely then it would be a revision
|
|
@ajf58 you asked in #89527 (comment) to address the 4MB/16MB variants for the RP2040-Plus board. This PR implements this as two revisions. Would you be so kind and have a look at this PR? |
ajf58
left a comment
ajf58
left a comment
There was a problem hiding this comment.
Sorry, I know it results in a lot of copy paste (feels a bit gross), but I feel like this might be a more Zephyr-like approach.
There was a problem hiding this comment.
I don't think I can do a multi-line suggestion, but I think the more Zephyr-y way of doing this would be to define multiple boards here. Like this:
boards:
- name: rp2040_plus
full_name: RP2040-Plus
vendor: waveshare
socs:
- name: rp2040
- name: rp2040_plus_16m
full_name: RP2040-Plus-16MB
vendor: waveshare
socs:
- name: rp2040
This would mean the full_name in Zephyr == Part Number at https://www.waveshare.com/rp2040-plus.htm?sku=23503 and https://www.waveshare.com/rp2040-plus.htm?sku=20290
dsch
changed the title
The RP2040-Plus board with 16MB has a dedicated part number which makes it a dedicated board. Signed-off-by: David Schneider <[email protected]>
|
| config BOARD_RP2040_PLUS | ||
| bool | ||
| select RP2_FLASH_W25Q080 | ||
|
|
||
| config BOARD_RP2040_PLUS_16MB | ||
| bool | ||
| select RP2_FLASH_W25Q080 |
There was a problem hiding this comment.
can't be adding bool to these symbols, will have to do a workaround similar to:
config BOARD_HAS_W25Q080
bool
default y if BOARD_RP2040_PLUS || BOARD_RP2040_PLUS_16MB
select RP2_FLASH_W25Q080
though this still doesn't make sense as the w25q080 is an 8Mbit part?
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
4 participants
This board is available with 4MB and 16MB flash.