drivers: reset: rpi_pico: wait for reset deassertion #92321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform: Raspberry Pi Pico
github-actions
bot
requested review from
ThreeEights,
ajf58,
decsny,
soburi and
yonsch
dsseng
force-pushed
the
main
branch
2 times, most recently
from
7c3f9d8 to
15d0281
Compare
dsseng
added a commit
to dsseng/zephyr
that referenced
this pull request
Jul 5, 2025
… deassertion Failing to do so can lead to e.g. PIO not being ready by the time a driver tries to use it. pico-sdk also does block on this register in its reset deassertion routines. Signed-off-by: Dmitrii Sharshakov <[email protected]>
soburi
reviewed
Jul 8, 2025
dsseng
added a commit
to dsseng/zephyr
that referenced
this pull request
Jul 20, 2025
No need to toggle reset line manually, use the standard reset API. This improves code searchability and aids debugging. Requires zephyrproject-rtos#92321 to make sure reset deassertion is waited for. Signed-off-by: Dmitrii Sharshakov <[email protected]>
dsseng
added a commit
to dsseng/zephyr
that referenced
this pull request
Jul 20, 2025
No need to toggle reset line manually, use the standard reset API. This improves code searchability and aids debugging. Requires zephyrproject-rtos#92321 to make sure reset deassertion is waited for. Signed-off-by: Dmitrii Sharshakov <[email protected]>
dsseng
added a commit
to dsseng/zephyr
that referenced
this pull request
Jul 20, 2025
No need to toggle reset line manually, use the standard reset API. This improves code searchability and aids debugging. Requires zephyrproject-rtos#92321 to make sure reset deassertion is waited for. Signed-off-by: Dmitrii Sharshakov <[email protected]>
Member
Author
|
@soburi @ThreeEights @ajf58 could you please take a look at this driver rewrite? |
soburi
requested changes
Aug 1, 2025
Use HAL functions, which also wait for reset to complete. Remove unused register size and active-low DT props. Signed-off-by: Dmitrii Sharshakov <[email protected]>
|
ajf58
approved these changes
Aug 8, 2025
Contributor
ajf58
left a comment
ajf58
left a comment
There was a problem hiding this comment.
Sorry for taking so long to review this.
dsseng
added a commit
to dsseng/zephyr
that referenced
this pull request
Aug 11, 2025
No need to toggle reset line manually, use the standard reset API. This improves code searchability and aids debugging. Requires zephyrproject-rtos#92321 to make sure reset deassertion is waited for. Signed-off-by: Dmitrii Sharshakov <[email protected]>
dsseng
added a commit
to dsseng/zephyr
that referenced
this pull request
Aug 17, 2025
No need to toggle reset line manually, use the standard reset API. This improves code searchability and aids debugging. Requires zephyrproject-rtos#92321 to make sure reset deassertion is waited for. Signed-off-by: Dmitrii Sharshakov <[email protected]>
dsseng
added a commit
to dsseng/zephyr
that referenced
this pull request
Aug 17, 2025
No need to toggle reset line manually, use the standard reset API. This improves code searchability and aids debugging. Requires zephyrproject-rtos#92321 to make sure reset deassertion is waited for. Signed-off-by: Dmitrii Sharshakov <[email protected]>
dsseng
added a commit
to dsseng/zephyr
that referenced
this pull request
Aug 17, 2025
No need to toggle reset line manually, use the standard reset API. This improves code searchability and aids debugging. Requires zephyrproject-rtos#92321 to make sure reset deassertion is waited for. Signed-off-by: Dmitrii Sharshakov <[email protected]>
dsseng
added a commit
to dsseng/zephyr
that referenced
this pull request
Aug 17, 2025
No need to toggle reset line manually, use the standard reset API. This improves code searchability and aids debugging. Requires zephyrproject-rtos#92321 to make sure reset deassertion is waited for. Signed-off-by: Dmitrii Sharshakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing to do so can lead to e.g. PIO not being ready by the time
a driver tries to use it.
pico-sdk also does block on this register in
its reset deassertion routines.
Signed-off-by: Dmitrii Sharshakov [email protected]