Avoid making difference between 15pins and 22pins raspberry pi CSI connector #91983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: STM32
github-actions
bot
requested review from
FRASTM,
GeorgeCGV,
avisconti,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
henrikbrixandersen,
jfischer-no,
kartben,
marwaiehm-st,
mathieuchopstm and
mnkp
erwango
previously approved these changes
Jun 23, 2025
mathieuchopstm
previously approved these changes
Jun 23, 2025
josuah
previously approved these changes
Jun 23, 2025
gautierg-st
previously approved these changes
Jun 23, 2025
kartben
requested changes
Jun 26, 2025
| # Copyright 2025 STMicroelectronics | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| description: | |
There was a problem hiding this comment.
add a title:, please, otherwise this will look really odd/wrong in boards' documentation
I guess you want something like "GPIO pins exposed on the Raspberry Pi CSI Camera connector".
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| description: | | ||
| There are 2 variants of the Raspberry Pi CSI camera connector. Either 15pins |
There was a problem hiding this comment.
kind of a nit but since you need to add the title anyway:
15pins --> 15-pin
22pins --> 22-pin
fix everywhere
added 3 commits
June 26, 2025 12:49
…ctor Update the RaspberryPi CSI camera connector nexus gpio in order to only expose the list of GPIO pins in order to support both 15-pin and 22-pin connectors as well as 15-pin to 22-pin conversion cables. Signed-off-by: Alain Volmat <[email protected]>
Following renaming of the raspberry csi connector nexus, rename all places when csi 22pins is mentioned to only keep csi instead. Signed-off-by: Alain Volmat <[email protected]>
Following renaming of the raspberry csi connector nexus, rename all places when csi 22pins is mentioned to only keep csi instead. Signed-off-by: Alain Volmat <[email protected]>
avolmat-st
dismissed stale reviews from josuah, mathieuchopstm, and erwango
via
3300de6
avolmat-st
force-pushed
the
pr-video_csi-nexus-fix
branch
from
c08d628 to
3300de6
Compare
|
Thanks @kartben, I updated the yaml file and used your proposal as title. |
|
kartben
approved these changes
Jun 26, 2025
josuah
approved these changes
Jun 26, 2025
gautierg-st
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first nexus has been introduced for the raspberry pi 22pins CSI connector. There are also 15pins CSI connectors as well as also 15pins to 22pins conversion cables.
As far as GPIO are concerned there are only 4 pins importants in those connectors, IO0 / IO1 / I2C_SCL and I2C_SDA.
The other pins are directly connected to CSI PHY for which Zephyr doesn't have much to do.
In order to avoid having to deal with 2 kinds of connectors / nexus and having to figure a way to deal with cases when a conversion cable is being used, simply have the gpio-nexus list only the 4 GPIOs.
The other commits update DTSI and overlay to update the csi-22pins into simply csi.
Follwing this, I will update the PR #91837 and PR #88011 should also be updated.