You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation did not state clearly that any zero-latency IRQ must also be declared as a direct ISR. This is critical because failure to do so may cause race conditions between the ZLI and regular ISRs when executing the preable/postamble code in regular interrupts.
Should probably just document that the return value is unused, or play some games to enable the function to be declared void.
It's tricker than that. The return value is not unused, it's actually used by the direct ISR framework, so the direct ISR of a ZLI must return 0, otherwise we will have kernel code executed in ZLI context. Documented that.
The documentation did not state clearly that any zero-latency IRQ must
also be declared as a direct ISR. This is critical because failure to do
so may cause race conditions between the ZLI and regular ISRs when
executing the preable/postamble code in regular interrupts.
Signed-off-by: Carles Cufi <[email protected]>
Now that we expect more changes similar to #91119, should there be a small mention about this in either migration guide or release notes (whichever is the right place) to attract more attention to this?
Now that we expect more changes similar to #91119, should there be a small mention about this in either migration guide or release notes (whichever is the right place) to attract more attention to this?
I will add a note to the migration guide after this PR and #91078 are merged.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
requested review from
TaiJuWu,
ceolin,
cfriedt,
dcpleung,
nashif and
npitre
carlescufi
requested review from
wearyzen
and removed request for
TaiJuWu,
ceolin,
cfriedt,
dcpleung,
nashif and
npitre
The documentation did not state clearly that any zero-latency IRQ must also be declared as a direct ISR. This is critical because failure to do so may cause race conditions between the ZLI and regular ISRs when executing the preable/postamble code in regular interrupts.