-
Notifications
You must be signed in to change notification settings - Fork 8.2k
boards: Introduce AI-WB2-12F #89049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: Introduce AI-WB2-12F #89049
Conversation
2e6f6e9 to
ae90336
Compare
nordicjm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
binding update should be before dts that uses it but likely not an issue with CI
| @@ -0,0 +1,52 @@ | |||
| /* | |||
| * Copyright (c) 2024-2025 MASSDRIVER EI (massdriver.space | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Copyright (c) 2024-2025 MASSDRIVER EI (massdriver.space | |
| * Copyright (c) 2024-2025 MASSDRIVER EI (massdriver.space) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
Marking DNM until #89021 is solved due to likely requiring some path changes. |
3b881be to
c4a2b86
Compare
|
Sorry for rebase, I only changed |
|
Ci fail not related to pr. |
| various security features. The external interfaces include SDIO, SPI, UART, | ||
| I2C, IR remote, PWM, ADC, DAC, PIR and GPIO. | ||
|
|
||
| The BL602 Development Board features a SiFive E24 32 bit RISC-V CPU with FPU, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E.g this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind the copy-paste of the blurb but just fix the name of the board :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean 'The BL602 Development Board' ?
Should it be 'This BL602 Development Board'? 'The BL602 WB2 12F Module Development Board'?
| CONFIG_SERIAL=y | ||
|
|
||
| CONFIG_UART_CONSOLE=y | ||
| CONFIG_UART_BFLB=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| CONFIG_UART_BFLB=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cant, 'default y' is missing from the KConfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a commit to fix it actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks! You should also drop it from bl604dvk defconfig while you're here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
Sigh looks like I can't re-open as it's not my PR, possibly. Can you please do it @VynDragon, as a workaround to kick CI |
|
Iame not able to |
|
well now i can wtf. |
|
Nevermind, I cannot, the buttonm was ungreyed for some reason? |
|
Maybe a force push could re-open. |
|
re-open. |
fumy, it showed to me to re-open with a message but did not performed : ( |
|
Tried pushing a rebase, and modifying commit message... |
|
test 5 |
Add zb prefix Signed-off-by: Camille BAUD <[email protected]>
This introduces the Ai-Thinker BL602 WB2 development board Signed-off-by: Camille BAUD <[email protected]>
Adds missing default y to bflb Kconfig Signed-off-by: Camille BAUD <[email protected]>
remove CONFIG_UART_BFLB because default y was added to Kconfig so it enables automatically Signed-off-by: Camille BAUD <[email protected]>
| board: | ||
| name: ai_wb2_12f | ||
| full_name: Ai-Thinker WB2-12F development board | ||
| vendor: bflb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed the vendor here is incorrect (main - and only? - consequence being that it shows incorrect info in the documentation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should probably also added in the vendor-prefixes list, is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which you've already done in this PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or so I thought, sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh?
Introduces the Ai-Thinker WB2 development board.
depends on #89021