Skip to content

Conversation

@VynDragon
Copy link
Contributor

@VynDragon VynDragon commented Apr 24, 2025

Introduces the Ai-Thinker WB2 development board.

depends on #89021

@VynDragon VynDragon force-pushed the ai_wb2_12f branch 3 times, most recently from 2e6f6e9 to ae90336 Compare April 24, 2025 18:08
@VynDragon VynDragon marked this pull request as ready for review April 24, 2025 18:10
@github-actions github-actions bot requested review from decsny, galak and rruuaanng April 24, 2025 18:11
@VynDragon VynDragon requested a review from nandojve April 24, 2025 18:24
nordicjm
nordicjm previously approved these changes Apr 25, 2025
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

binding update should be before dts that uses it but likely not an issue with CI

rruuaanng
rruuaanng previously approved these changes Apr 25, 2025
@@ -0,0 +1,52 @@
/*
* Copyright (c) 2024-2025 MASSDRIVER EI (massdriver.space
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) 2024-2025 MASSDRIVER EI (massdriver.space
* Copyright (c) 2024-2025 MASSDRIVER EI (massdriver.space)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@VynDragon
Copy link
Contributor Author

Marking DNM until #89021 is solved due to likely requiring some path changes.

@VynDragon VynDragon added the DNM This PR should not be merged (Do Not Merge) label Apr 25, 2025
@VynDragon VynDragon dismissed stale reviews from rruuaanng and nordicjm via 3b881be April 25, 2025 14:08
@VynDragon VynDragon force-pushed the ai_wb2_12f branch 2 times, most recently from 3b881be to c4a2b86 Compare April 28, 2025 17:39
@VynDragon VynDragon removed the DNM This PR should not be merged (Do Not Merge) label Apr 28, 2025
@VynDragon
Copy link
Contributor Author

Sorry for rebase, I only changed #include <bouffalolab/bl60x.dtsi> to #include <bflb/bl60x.dtsi>

@VynDragon
Copy link
Contributor Author

Ci fail not related to pr.

various security features. The external interfaces include SDIO, SPI, UART,
I2C, IR remote, PWM, ADC, DAC, PIR and GPIO.

The BL602 Development Board features a SiFive E24 32 bit RISC-V CPU with FPU,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the copy-paste of the blurb but just fix the name of the board :)

Copy link
Contributor Author

@VynDragon VynDragon Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean 'The BL602 Development Board' ?
Should it be 'This BL602 Development Board'? 'The BL602 WB2 12F Module Development Board'?

CONFIG_SERIAL=y

CONFIG_UART_CONSOLE=y
CONFIG_UART_BFLB=y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CONFIG_UART_BFLB=y

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant, 'default y' is missing from the KConfig.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit to fix it actually.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! You should also drop it from bl604dvk defconfig while you're here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@nandojve nandojve requested a review from kartben April 30, 2025 15:59
kartben
kartben previously approved these changes Apr 30, 2025
nandojve
nandojve previously approved these changes Apr 30, 2025
@kartben kartben closed this Apr 30, 2025
@kartben
Copy link
Contributor

kartben commented Apr 30, 2025

Sigh looks like I can't re-open as it's not my PR, possibly. Can you please do it @VynDragon, as a workaround to kick CI

@VynDragon
Copy link
Contributor Author

Iame not able to

@VynDragon
Copy link
Contributor Author

well now i can wtf.

@VynDragon
Copy link
Contributor Author

Nevermind, I cannot, the buttonm was ungreyed for some reason?

@nandojve
Copy link
Member

Maybe a force push could re-open.

@nandojve
Copy link
Member

re-open.

@nandojve
Copy link
Member

re-open.

fumy, it showed to me to re-open with a message but did not performed : (

@VynDragon
Copy link
Contributor Author

Tried pushing a rebase, and modifying commit message...

@VynDragon
Copy link
Contributor Author

test 5

@VynDragon VynDragon reopened this Apr 30, 2025
Add zb prefix

Signed-off-by: Camille BAUD <[email protected]>
This introduces the Ai-Thinker BL602 WB2 development board

Signed-off-by: Camille BAUD <[email protected]>
Adds missing default y to bflb Kconfig

Signed-off-by: Camille BAUD <[email protected]>
remove CONFIG_UART_BFLB because default y was added to
Kconfig so it enables automatically

Signed-off-by: Camille BAUD <[email protected]>
@VynDragon VynDragon dismissed stale reviews from nandojve and kartben via 30a5eb5 April 30, 2025 19:17
@kartben kartben merged commit 0168ed4 into zephyrproject-rtos:main May 1, 2025
28 checks passed
board:
name: ai_wb2_12f
full_name: Ai-Thinker WB2-12F development board
vendor: bflb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed the vendor here is incorrect (main - and only? - consequence being that it shows incorrect info in the documentation)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should probably also added in the vendor-prefixes list, is that correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which you've already done in this PR :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or so I thought, sorry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Devicetree area: UART Universal Asynchronous Receiver-Transmitter platform: Bouffalo Lab

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants