logging: Fix fail when log locally disabled #8840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When log is locally disabled then structures associated with the module are not created. Logger API macros were evaluating those structues even when log was disabled for given module. That resulted in compilation error. Macros has been improved to not touch those structures when log is disabled for given module. Signed-off-by: Krzysztof Chruscinski <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #8840 +/- ##
=======================================
Coverage 52.32% 52.32%
=======================================
Files 195 195
Lines 24730 24730
Branches 5140 5140
=======================================
Hits 12941 12941
Misses 9715 9715
Partials 2074 2074
Continue to review full report at Codecov.
|
Contributor
Author
|
this PR should solve the same issue as #8828 tried to solve. However, it has advantage that it does not remove completely log API when it is disabled but keeps the C code underneath (but compiler removes it). |
jukkar
approved these changes
Jul 11, 2018
Member
jukkar
left a comment
jukkar
left a comment
There was a problem hiding this comment.
Thanks @nordic-krch, this fixed the issue I was seeing.
carlescufi
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When log is locally disabled then structures associated with the module
are not created. Logger API macros were evaluating those structues even
when log was disabled for given module. That resulted in compilation
error. Macros has been improved to not touch those structures when
log is disabled for given module.
Signed-off-by: Krzysztof Chruscinski [email protected]