drivers: Update MCUX I2C RTIO driver with SDK changes #88315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the driver to account for variations in the SDK driver when it uses the instance number instead of the base address. Applying 49bdcd2 on RTIO-version. Co-authored-by: Mahesh Mahadevan <[email protected]> Signed-off-by: Luis Ubieda <[email protected]>
Some NXP SoC's have a FlexComm interface that manages the interrupts. Applying 482e39e on RTIO-version. Authored-by: Mahesh Mahadevan <[email protected]> Signed-off-by: Luis Ubieda <[email protected]>
The Low Power Flexcomm driver manages the interrupt handling and provides an API to register interrupt callbacks. Register the NXP LPI2C interrupt handler. Applying dca6e64 on RTIO-version. Authored-by: Mahesh Mahadevan <[email protected]> Signed-off-by: Luis Ubieda <[email protected]>
ubieda
added
backport v3.7-branch
github-actions
bot
added
area: I2C
platform: NXP Drivers
github-actions
bot
requested review from
Raymond0225,
dbaluta,
decsny,
dleach02,
manuargue,
mmahadevan108 and
teburd
teburd
previously approved these changes
Apr 9, 2025
@decsny I'm confused, please ellaborate:
Please provide feedback so we're on the same page before iterating. |
bperseghetti
previously approved these changes
Apr 14, 2025
I see, I confused them for the same file. In that case please follow the same paradigm as is being done for the other file. (or if you're feeling really ambitious, make some common file to share this, but I don't suggest that for this PR) |
Determine if lpflexcomm wrapped lpi2c by instance and connect irq differently dependending on that to support platforms with both flexcomm wrapped and unwrapped lpi2c's. Applying c1286a8 to RTIO version. Authored-by: Declan Snyder <[email protected]> Signed-off-by: Luis Ubieda <[email protected]>
decsny
approved these changes
Apr 14, 2025
bperseghetti
approved these changes
Apr 14, 2025
|
just ran into this myself, thanks for fixing |
teburd
approved these changes
Apr 14, 2025
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the driver to account for variations in the SDK driver
when it uses the instance number instead of the base address.
Changes come from #70866 and #83704 applied to I2C RTIO.
Fixes #88319.
Testing
Built for MCXN947 and tested I2C commands work.
Output: