Skip to content

Conversation

@therealprof
Copy link
Contributor

This patch adds support for Ethernet in the STM32F7 famlily
microcontrollers

Signed-off-by: Daniel Egger [email protected]

This patch adds support for Ethernet in the STM32F7 famlily
microcontrollers

Signed-off-by: Daniel Egger <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #8663 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8663      +/-   ##
==========================================
- Coverage    64.3%   64.29%   -0.01%     
==========================================
  Files         440      440              
  Lines       42093    42093              
  Branches     7046     7046              
==========================================
- Hits        27066    27065       -1     
- Misses      11827    11828       +1     
  Partials     3200     3200
Impacted Files Coverage Δ
samples/philosophers/src/main.c 96.87% <0%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9a1f0...3b149bf. Read the comment docs.

@erwango erwango added the platform: STM32 ST Micro STM32 label Jul 2, 2018
@therealprof
Copy link
Contributor Author

@erwango Can you review please? This is a broken out patch from a larger patch set to bring up the Nucleo-F746ZG including networking; I tend to get easily confused with too many open construction sites. ;)

@erwango erwango self-requested a review July 4, 2018 13:51
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is to add ETH pinmux to the familly, why not adding PC2, PC3?

@therealprof
Copy link
Contributor Author

@erwango Because they're not needed. This is modelled after the pinmux configuration for the F4 which also doesn't define them. I also have a similar patch for the F2 once support lands.

I don't know what PC2 and PC3 do from the top of my head but I can look it up and add them if you prefer.

@erwango
Copy link
Member

erwango commented Jul 4, 2018

@therealprof , well looking to a F7 datasheet, these also have ethernet function

@therealprof
Copy link
Contributor Author

@erwango Those are for MII operation, you should find a few more pins required for MII mode but I'm not sure whether the driver actually supports MII mode at the moment, the typical implementations (also the one on the Nucleos) use RMII mode.

@erwango
Copy link
Member

erwango commented Jul 4, 2018

@therealprof , ok, my bad, I'm not too much familiar with eth

@galak galak merged commit b6da8be into zephyrproject-rtos:master Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: STM32 ST Micro STM32

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants