rp2350: Only add IMAGE_DEF for apps at start of flash. #86294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
From what I see that this issue may also be easily resolved with #79460, so eventually this PR is probably superfluous. |
Manu3l0us
changed the title
Author
|
I removed the WIP "label" as I don't plan to add something currently. The driver is working fine in my private branch |
Contributor
|
@Manu3l0us to |
Contributor
|
@soburi Zephyr team |
Author
|
@hanan619 Thanks for pointing out. I always flashed using a hex file with a debug probe. Therefore I didn't detect it |
soburi
previously approved these changes
Apr 15, 2025
Manu3l0us
force-pushed
the
fix_image_def_for_bootloader
branch
from
2996e92 to
24e199d
Compare
Manu3l0us
force-pushed
the
fix_image_def_for_bootloader
branch
from
24e199d to
9bcd550
Compare
The image_def header shall not be added to apps that are booted by a bootloader, e.g. mcuboot. Added proper handling for UF2 by hanan619. Signed-off-by: Manuel Aebischer <[email protected]>
Manu3l0us
force-pushed
the
fix_image_def_for_bootloader
branch
from
9bcd550 to
be83852
Compare
soburi
approved these changes
Apr 19, 2025
kartben
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image_def header shall not be added to apps that are booted by a bootloader, e.g. mcuboot.
@soburi This is another patch I prepared during the RP2350 pull request by @ajf58. As I have started to use mcuboot after fixing the flash driver, I had the problem that also the application image loaded by the bootloader had the image_def block in it.