Bluetooth: Controller: Fix extended scanning assertion and fix single timer direction finding support #86174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvinayak
force-pushed
the
github_single_timer_df_fix
branch
4 times, most recently
from
6fc0e2b to
870ffdc
Compare
Fix active mode extended scanning assert raised when calling radio_tmr_start_us() due to stale radio_tmr_end_get() value. Active mode extended scanning did not drop reception of ADV_EXT_IND PDU when setup to receive ADV_SCAN_RSP PDUs. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix single timer use end time capture from being disabled as end time and timer clear use the same PPI. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix end time capture be on radio event end irrespective of direction finding support. Let the timer clear use radio end or radio phy end, for no direction finding or direction finding support, respectively. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Rename the single timer clear event define name based on direction finding support. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix use of single timer software tIFS switching to support direction finding. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_single_timer_df_fix
branch
from
870ffdc to
ee10f4b
Compare
zephyrbot
requested review from
carlescufi,
erbr-ot,
mtpr-ot,
thoh-ot and
wopu-ot
cvinayak
commented
Feb 26, 2025
Comment on lines
+92
to
+93
| nrf_radio_publish_set(NRF_RADIO, HAL_NRF_RADIO_EVENT_END, | ||
| HAL_RADIO_END_TIME_CAPTURE_PPI); |
There was a problem hiding this comment.
This indentation change is intentional so that this file is included in the same commit as the fix in the radio_nrf5_ppi.h for single timer support. Both use of PPI and DPPI shall use the Radio END event to capture the last bit in the PDU.
cvinayak
added
bug
15 tasks
cvinayak
changed the title
Thalley
approved these changes
Feb 27, 2025
carlescufi
approved these changes
Feb 28, 2025
This was referenced Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix active mode extended scanning assert raised when calling radio_tmr_start_us() due to stale radio_tmr_end_get() value. Active mode extended scanning did not drop reception of ADV_EXT_IND PDU when setup to receive ADV_SCAN_RSP PDUs.
Fix use of single timer software tIFS switching to support direction finding.
Listed in #82399.