doc: coding guidelines: move safety related blurb to saftey section #84058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Documentation
area: Coding Guidelines
zephyrbot
requested review from
carlescufi,
jfischer-no,
kartben,
keith-zephyr and
simhein
nashif
force-pushed
the
topic/doc/coding_guidelines_stages
branch
from
831368c to
05c3535
Compare
nashif
changed the title
Move some of the historical safety related language and enforcement strategy re coding guidelines to the safety section. The coding guidelines are and have been in effect for a while now, but it seems this introduction text is confusing contributors. Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
topic/doc/coding_guidelines_stages
branch
from
05c3535 to
7f84df6
Compare
kartben
approved these changes
Jan 16, 2025
Contributor
kartben
left a comment
kartben
left a comment
There was a problem hiding this comment.
Works for me to remove the confusion for folks stumbling upon coding guidelines and thinking they might not be enforced yet based on the description of the stages.
Confusion remains for anyone looking at this in its new location IMO, but that's probably for the Safety WG to help clean up in a second step.
Thanks @nashif!
pdgendt
approved these changes
Jan 16, 2025
de-nordic
reviewed
Jan 16, 2025
Comment on lines
+161
to
+162
| Reviewers/approvers can block pull-requests due to violations of the coding guidelines | ||
| in pull-requests across the codebase. |
Contributor
There was a problem hiding this comment.
This comment just highlights added section (no change requested).
de-nordic
approved these changes
Jan 16, 2025
Contributor
de-nordic
left a comment
de-nordic
left a comment
There was a problem hiding this comment.
Thanks for the update.
keith-zephyr
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some of the historical safety related langugae and enforcement strategy re
coding guidelines to the safety section.
The coding guidelines are and have been in effect for a while now, but it seems
this introduction text is confusing contributors.
Signed-off-by: Anas Nashif [email protected]