tests: drivers: gpio: gpio_basic_api: Enable test on rpi_pico #83427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soburi
force-pushed
the
rpi_pico_gpio_disconnected
branch
from
7399159 to
8748061
Compare
zephyrbot
added
platform: Raspberry Pi Pico
If GPIO_DISCONNECTED is requested with gpio_pin_configure, it will return -ENOTSUP since rpi_pico does not support it. Signed-off-by: TOKITA Hiroshi <[email protected]>
soburi
force-pushed
the
rpi_pico_gpio_disconnected
branch
from
8748061 to
55dfd2c
Compare
soburi
force-pushed
the
rpi_pico_gpio_disconnected
branch
from
55dfd2c to
cb6058d
Compare
soburi
commented
Jan 31, 2025
Member
Author
There was a problem hiding this comment.
henrikbrixandersen
previously approved these changes
Jan 31, 2025
Member
Author
|
@ThreeEights |
Add an overlay for `rpi_pico` and `rpi_pico2` to run this test. Signed-off-by: TOKITA Hiroshi <[email protected]>
soburi
force-pushed
the
rpi_pico_gpio_disconnected
branch
from
cb6058d to
79ee6dc
Compare
Member
Author
|
@henrikbrixandersen @ThreeEights I have only changed the GPIO pin numbers a little. |
henrikbrixandersen
approved these changes
Jan 31, 2025
ThreeEights
approved these changes
Jan 31, 2025
Member
Author
|
@kartben @fabiobaltieri |
fabiobaltieri
approved these changes
Feb 3, 2025
kartben
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that gpio_basic_api testing had not been performed in rpi_pico, so I added this setting and performed testing.
As a result, GPIO_DISCONNECTED was being mishandled, so I have fixed this.
For rpi_pico2, due to an errata for RP2350-E9, INPUT and PULLDOWN cannot be enabled
simultaneously on the RP2350.
Set CONFIG_SKIP_PULL_TEST to avoid the test that causes the issue.