drivers: udc: add support for USB device on Renesas RA USBFS HWIP #83358

thenguyenyf · 2024-12-24T11:26:07Z

This PR to add support for USB device on USBFS port of Renesas RA family

Add missing uclk clock node on RA2A1
Remove old binding of renesas,ra-usb → renesas,ra-usbhs and renesas,ra-usbfs
Remove unused interrupts of USBHS device in Renesas RA dts
Add driver support for Renesas RA USBFS module
Add support for USB device on Renesas RA USBFS port

zephyrbot · 2024-12-24T11:27:09Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_renesas	zephyrproject-rtos/hal_renesas@`abca7ee`	zephyrproject-rtos/hal_renesas@`3237c5d`	zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

thaoluonguw · 2025-01-21T08:44:12Z

@thenguyenyf : Please rebase to solve conflict.

thenguyenyf · 2025-01-23T01:24:50Z

Last push to update the hal_renesas rev, because it was merged, and solve the conflict

jfischer-no · 2025-01-23T10:51:08Z

drivers/usb/udc/udc_renesas_ra.c

This can be normal function as you have dev parameter, no need to put it inside macro.

jfischer-no · 2025-01-23T10:51:48Z

drivers/usb/udc/udc_renesas_ra.c

Variable definition should be at the top of a block.

jfischer-no · 2025-01-23T10:53:05Z

drivers/usb/udc/udc_renesas_ra.c

Can be normal function, no need to place it inside macro.

jfischer-no · 2025-01-23T10:54:00Z

drivers/usb/udc/udc_renesas_ra.c

Stray change, no need to introduce id.

jfischer-no · 2025-01-23T10:55:28Z

drivers/usb/udc/udc_renesas_ra.c

.irq_config_func = renesas_ra_usb_irq_config##id };

Style issue, please fix it everywhere.

thenguyenyf · 2025-02-03T08:15:19Z

Last push to rebase main branch and solve conflict

Update revision of hal_renesas module to add support of UDC on Renesas RA USBFS module Signed-off-by: The Nguyen <[email protected]>

Add missing clock node of uclk on Renesas RA2A1 SoC Signed-off-by: The Nguyen <[email protected]>

thenguyenyf · 2025-02-12T10:29:16Z

Last push to rebase main and solve conflict

thenguyenyf · 2025-02-12T10:31:25Z

Hi @jfischer-no , @KhiemNguyenT , @tmon-nordic , @thaoluonguw . Could you please review if this PR can be merged?

jfischer-no · 2025-02-13T13:31:27Z

drivers/usb/udc/udc_renesas_ra.c

+		.udc_cfg =                                                                         \
+			{                                                                          \
+				.module_number = USB_RENESAS_RA_MODULE_NUMBER(DT_INST_PARENT(n)),  \


.udc_cfg = { \ .module_number = USB_RENESAS_RA_MODULE_NUMBER(DT_INST_PARENT(n)), \

First commit to add support for USBFS module on Renesas RA - Remove renesas,ra-usb binding - Add 2 new binding for Renesas RA USBFS and USBHS - Remove unused interrupts of USBHS Signed-off-by: The Nguyen <[email protected]>

Add device node of usbfs on Renesas RA SoC Signed-off-by: The Nguyen <[email protected]>

Add phys-clock to usbhs node in case internal phys-clock-src is used Signed-off-by: The Nguyen <[email protected]>

Add USB support on USBFS port on these boards: - RA8: ek_ra8m1, ek_ra8d1, mck_ra8t1 - RA6: ek_ra6m1, ek_ra6m2, ek_ra6m3, ek_ra6m4, ek_ra6m5 - RA4: ek_ra4m2, ek_ra4m3, voice_ra4e1 Signed-off-by: The Nguyen <[email protected]>

zephyrbot added manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) labels Dec 24, 2024

thenguyenyf marked this pull request as ready for review December 24, 2024 14:32

zephyrbot added platform: Renesas RA Renesas Electronics Corporation, RA area: USB Universal Serial Bus labels Dec 24, 2024

zephyrbot requested review from KhiemNguyenT, duynguyenxa, jfischer-no, soburi, thaoluonguw and tmon-nordic December 24, 2024 14:33

zephyrbot assigned jfischer-no Dec 24, 2024

tmon-nordic previously approved these changes Jan 9, 2025

View reviewed changes

thaoluonguw previously approved these changes Jan 21, 2025

View reviewed changes

thenguyenyf dismissed stale reviews from thaoluonguw and tmon-nordic via 94f4294 January 23, 2025 01:23

thenguyenyf force-pushed the support_renesas_ra_usbfs branch from 01764f3 to 94f4294 Compare January 23, 2025 01:23

thenguyenyf requested review from thaoluonguw and tmon-nordic January 23, 2025 01:24

zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Jan 23, 2025

jfischer-no requested changes Jan 23, 2025

View reviewed changes

thenguyenyf force-pushed the support_renesas_ra_usbfs branch 2 times, most recently from 1002014 to 38610d4 Compare February 3, 2025 08:10

tmon-nordic previously approved these changes Feb 3, 2025

View reviewed changes

thenguyenyf dismissed tmon-nordic’s stale review via 1c498e8 February 4, 2025 01:08

duynguyenxa previously approved these changes Feb 7, 2025

View reviewed changes

soburi mentioned this pull request Feb 9, 2025

entropy: rpi_pico: implement entropy driver for RP2350 #83346

Open

thenguyenyf added 2 commits February 12, 2025 15:04

manifest: update rev of hal_renesas to support USBFS module

2003b5f

Update revision of hal_renesas module to add support of UDC on Renesas RA USBFS module Signed-off-by: The Nguyen <[email protected]>

dts: arm: renesas: add uclk clock node for ra2a1

31d6ed9

Add missing clock node of uclk on Renesas RA2A1 SoC Signed-off-by: The Nguyen <[email protected]>

thenguyenyf dismissed stale reviews from duynguyenxa and tmon-nordic via d237215 February 12, 2025 10:28

thenguyenyf force-pushed the support_renesas_ra_usbfs branch from 1c498e8 to d237215 Compare February 12, 2025 10:28

thenguyenyf requested review from duynguyenxa and tmon-nordic February 12, 2025 10:29

thaoluonguw previously approved these changes Feb 13, 2025

View reviewed changes

tmon-nordic previously approved these changes Feb 13, 2025

View reviewed changes

jfischer-no reviewed Feb 13, 2025

View reviewed changes

thenguyenyf added 4 commits February 14, 2025 09:38

drivers: udc: add UDC support for USBFS on Renesas RA family

20be99f

First commit to add support for USBFS module on Renesas RA - Remove renesas,ra-usb binding - Add 2 new binding for Renesas RA USBFS and USBHS - Remove unused interrupts of USBHS Signed-off-by: The Nguyen <[email protected]>

dts: arm: renesas: add UDC support for USBFS module

78d3385

Add device node of usbfs on Renesas RA SoC Signed-off-by: The Nguyen <[email protected]>

dts: arm: renesas: add phys-clock for usbhs node

19bd08f

Add phys-clock to usbhs node in case internal phys-clock-src is used Signed-off-by: The Nguyen <[email protected]>

thenguyenyf dismissed stale reviews from tmon-nordic and thaoluonguw via f1dcc3e February 14, 2025 02:41

thenguyenyf force-pushed the support_renesas_ra_usbfs branch from d237215 to f1dcc3e Compare February 14, 2025 02:41

thenguyenyf requested review from jfischer-no, thaoluonguw and tmon-nordic February 14, 2025 04:22

jfischer-no approved these changes Feb 14, 2025

View reviewed changes

thaoluonguw approved these changes Feb 14, 2025

View reviewed changes

KhiemNguyenT approved these changes Feb 14, 2025

View reviewed changes

KhiemNguyenT added this to the v4.1.0 milestone Feb 14, 2025

kartben merged commit c684fea into zephyrproject-rtos:main Feb 14, 2025
35 checks passed

thenguyenyf deleted the support_renesas_ra_usbfs branch April 24, 2025 11:26

drivers: udc: add support for USB device on Renesas RA USBFS HWIP #83358

drivers: udc: add support for USB device on Renesas RA USBFS HWIP #83358

Uh oh!

Conversation

thenguyenyf commented Dec 24, 2024

Uh oh!

zephyrbot commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaoluonguw commented Jan 21, 2025

Uh oh!

thenguyenyf commented Jan 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thenguyenyf commented Feb 3, 2025

Uh oh!

thenguyenyf commented Feb 12, 2025

Uh oh!

thenguyenyf commented Feb 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

zephyrbot commented Dec 24, 2024 •

edited

Loading