Skip to content

Conversation

@yishai1999
Copy link
Contributor

Add wrapper DEVICE_API macro to all pwm_driver_api instances.

@pdgendt
Copy link
Contributor

pdgendt commented Nov 28, 2024

You still had the led commit, need to drop that.

@yishai1999
Copy link
Contributor Author

You still had the led commit, need to drop that.

You're too quick!

@pdgendt
Copy link
Contributor

pdgendt commented Nov 28, 2024

You forgot drivers/pwm/pwm_rpi_pico.c

@yishai1999
Copy link
Contributor Author

You forgot drivers/pwm/pwm_rpi_pico.c

Missed it because it wasn't static. Fixed

@pdgendt
Copy link
Contributor

pdgendt commented Nov 28, 2024

Missed it because it wasn't static. Fixed

Careful making it static, but it looks fine in this case.

pdgendt
pdgendt previously approved these changes Nov 28, 2024
Add wrapper DEVICE_API macro to all pwm_driver_api instances.

Signed-off-by: Yishai Jaffe <[email protected]>
Filter for PWM devices when looking them up in dynamic shell commands.

Signed-off-by: Yishai Jaffe <[email protected]>
@pdgendt
Copy link
Contributor

pdgendt commented Dec 4, 2024

@anangl PTAL

@kartben kartben merged commit 3775e19 into zephyrproject-rtos:main Dec 6, 2024
24 checks passed
@yishai1999 yishai1999 deleted the linker-api-pwm branch December 7, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants