drivers: led: Place API into iterable section #82249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 tasks
zephyrbot
added
area: Sensors
zephyrbot
requested review from
Mani-Sadhasivam,
MaureenHelm,
VenkatKotakonda,
avisconti,
bbilas,
jeppenodgaard,
jvasanth1,
simonguinot,
teburd,
tristan-google,
ubieda and
yperess
Contributor
|
I think you missed |
yishai1999
force-pushed
the
linker-api-led
branch
from
542d716 to
ca0a7d2
Compare
pdgendt
previously approved these changes
Nov 28, 2024
simonguinot
previously approved these changes
Nov 28, 2024
simonguinot
reviewed
Nov 28, 2024
include/zephyr/drivers/led.h
Outdated
Contributor
There was a problem hiding this comment.
suggestion: this notation is quite heavy. Since we are using it several times, couldn't we just get the api pointer ?
pdgendt
reviewed
Nov 28, 2024
fabiobaltieri
previously approved these changes
Nov 29, 2024
Add wrapper DEVICE_API macro to all led_driver_api instances. Signed-off-by: Yishai Jaffe <[email protected]>
yishai1999
force-pushed
the
linker-api-led
branch
from
ca0a7d2 to
90dbd99
Compare
Filter for led devices when looking them up in dynamic shell commands. Signed-off-by: Yishai Jaffe <[email protected]>
pdgendt
approved these changes
Dec 1, 2024
fabiobaltieri
approved these changes
Dec 1, 2024
Contributor
|
@simonguinot PTAL |
simonguinot
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wrapper DEVICE_API macro to all led_driver_api instances.