subsys: net: Fix unaligned access to IPv6 address #82187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
jukkar,
pdgendt,
rlubos,
ssharks and
tbursztyka
Contributor
Author
|
Please note I have very limited resources for testing this fix. The only platform I have available is the Raspberry Pi Pico W. I don't know if other platforms exhibit the same failure, and I have no way to verify this fix doesn't cause issues on other platforms. |
ThreeEights
force-pushed
the
issue-82185-fix-unaligned-access
branch
from
aff5e15 to
9fc788f
Compare
Add UNALIGNED_GET() to prevent alignment fault when reading parts of the IPv6 address. Signed-off-by: Steve Boylan <[email protected]>
ThreeEights
force-pushed
the
issue-82185-fix-unaligned-access
branch
from
9fc788f to
c24006b
Compare
jukkar
approved these changes
Nov 28, 2024
Member
I am not worried about this because you can use the |
pdgendt
approved these changes
Nov 28, 2024
rlubos
approved these changes
Nov 28, 2024
Contributor
Author
Contributor
|
@ThreeEights The faulty function was introduced only 2 weeks ago, so it doesn't seem there's anything to backport here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UNALIGNED_GET() to prevent alignment fault when reading parts of the IPv6 address.
Fixes #82185