Skip to content

Conversation

@pdgendt
Copy link
Contributor

@pdgendt pdgendt commented Nov 27, 2024

Add wrapper DEVICE_API macro to all gpio_driver_api instances.

Add wrapper DEVICE_API macro to all gpio_driver_api instances.

Signed-off-by: Pieter De Gendt <[email protected]>
@yishai1999
Copy link
Contributor

Maybe adapt gpio_shell.c to use the API check instead of what it does now which is check that the gpio-controller property exists.

@henrikbrixandersen
Copy link
Member

Maybe adapt gpio_shell.c to use the API check instead of what it does now which is check that the gpio-controller property exists.

I'm a big fan of smaller, self-contained PRs. I'd suggest to leave all shell changes out of the PRs moving the API structs, and do small, incremental follow-up PRs instead.

@pdgendt
Copy link
Contributor Author

pdgendt commented Dec 1, 2024

Yes, I planned to do some follow-up PRs for that, this should be as simple as possible to review as many reviewers are pulled in.

Copy link
Member

@dleach02 dleach02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I get to be the assignee for all these "iterable section" PRs. Do we have a place in our documentation that should be updated with this guidance?

@pdgendt
Copy link
Contributor Author

pdgendt commented Dec 2, 2024

Somehow I get to be the assignee for all these "iterable section" PRs. Do we have a place in our documentation that should be updated with this guidance?

The device driver model page has been updated. I don't really know why you got assigned in all of these, but NXP drivers are changed too.

@fabiobaltieri fabiobaltieri merged commit 6d178f9 into zephyrproject-rtos:main Dec 2, 2024
24 checks passed
@pdgendt pdgendt deleted the linker-api-gpio branch December 2, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants