Skip to content

Conversation

@pdgendt
Copy link
Contributor

@pdgendt pdgendt commented Nov 27, 2024

Add wrapper DEVICE_API macro to all fuel_gauge_driver_api instances.

Add wrapper DEVICE_API macro to all fuel_gauge_driver_api instances.

Signed-off-by: Pieter De Gendt <[email protected]>
@pdgendt pdgendt force-pushed the linker-api-fuel_gauge branch from 3cc187c to 5112a98 Compare November 28, 2024 17:53
@pdgendt
Copy link
Contributor Author

pdgendt commented Dec 4, 2024

@teburd @aaronemassey PTAL

Copy link
Member

@aaronemassey aaronemassey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teburd @aaronemassey PTAL

Thanks for the @!

Do we need to do this for emulator APIs too? For example:

__subsystem struct fuel_gauge_emul_driver_api {

and

__subsystem struct bc12_emul_driver_api {

?

@pdgendt
Copy link
Contributor Author

pdgendt commented Dec 4, 2024

Do we need to do this for emulator APIs too?

Those API functions do not take a const struct device * as first argument, so they aren't really device APIs.

@nashif nashif merged commit 4483b7e into zephyrproject-rtos:main Dec 4, 2024
24 checks passed
@pdgendt pdgendt deleted the linker-api-fuel_gauge branch December 4, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants