drivers: fpga: Place API into iterable section #82176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 tasks
zephyrbot
added
platform: Microchip SAM
zephyrbot
requested review from
attie-argentum,
cfriedt,
de-nordic,
fkokosinski,
henrikbrixandersen,
ibirnbaum,
michalsimek,
mnkp,
msierszulski,
nandojve,
rghaddab,
stephanosio and
tgorochowik
cfriedt
reviewed
Nov 27, 2024
Member
cfriedt
left a comment
cfriedt
left a comment
There was a problem hiding this comment.
Looks good, but I would suggest holding off until @benediktibk 's ice40 PR is merged and then rebasing to avoid churn.
Contributor
Author
Sure, also note that the |
pdgendt
force-pushed
the
linker-api-fpga
branch
2 times, most recently
from
f4642e5 to
bef0872
Compare
kartben
requested changes
Nov 29, 2024
drivers/flash/flash_sam.c
Outdated
Contributor
There was a problem hiding this comment.
Doesn't belong to this commit :)
Add wrapper DEVICE_API macro to all fpga_driver_api instances. Signed-off-by: Pieter De Gendt <[email protected]>
pdgendt
force-pushed
the
linker-api-fpga
branch
from
bef0872 to
46d0cf0
Compare
Contributor
Author
|
Removed flash driver, rebased and added ice40 fpga drivers. |
kartben
approved these changes
Nov 29, 2024
henrikbrixandersen
approved these changes
Nov 29, 2024
tgorochowik
approved these changes
Nov 29, 2024
cfriedt
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wrapper DEVICE_API macro to all fpga_driver_api instances.