drivers: can: transceiver: Place API into iterable section #82146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 tasks
zephyrbot
requested review from
alexanderwachter,
henrikbrixandersen,
martinjaeger and
str4t0m
henrikbrixandersen
previously approved these changes
Nov 29, 2024
Add wrapper DEVICE_API macro to all can_transceiver_driver_api instances. Signed-off-by: Pieter De Gendt <[email protected]>
pdgendt
force-pushed
the
linker-api-can_transceiver
branch
from
4af84c1 to
66f4a4e
Compare
Contributor
Author
|
Asserts should have been removed. |
Member
Please elaborate? |
Contributor
Author
After a discord discussion the outcome was to not have asserts in the header files. This avoid breaking any downstream usages. Next to that, we have already the I3C driver API which encapsulates an I2C driver API. The asserts would make it more complex, and we shouldn't enforce these in the headers. |
henrikbrixandersen
approved these changes
Nov 29, 2024
martinjaeger
approved these changes
Dec 2, 2024
str4t0m
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wrapper DEVICE_API macro to all can_transceiver_driver_api instances.