drivers: can: Place API into iterable section #82128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdgendt
requested review from
aaillet,
dleach02,
karstenkoenig,
manuargue and
mmahadevan108
as code owners
80 tasks
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
alexanderwachter,
erwango,
gautierg-st,
henrikbrixandersen,
martinjaeger,
marwaiehm-st,
mathieuchopstm and
str4t0m
pdgendt
force-pushed
the
linker-api-can
branch
from
d73b53d to
e7cfa41
Compare
tejlmand
previously approved these changes
Nov 27, 2024
pdgendt
force-pushed
the
linker-api-can
branch
from
e7cfa41 to
a0e9912
Compare
Closed
pdgendt
force-pushed
the
linker-api-can
branch
from
f0c376b to
e9c92f4
Compare
Add wrapper DEVICE_API macro to all can_driver_api instances. Signed-off-by: Pieter De Gendt <[email protected]>
Update CAN shell commands to filter and verify the device's API type. Signed-off-by: Pieter De Gendt <[email protected]>
pdgendt
force-pushed
the
linker-api-can
branch
from
e9c92f4 to
ab27a9c
Compare
henrikbrixandersen
approved these changes
Nov 29, 2024
yishai1999
reviewed
Dec 1, 2024
| static void can_shell_tx_msgq_triggered_work_handler(struct k_work *work); | ||
| static void can_shell_rx_msgq_triggered_work_handler(struct k_work *work); | ||
|
|
||
| static bool can_device_check(const struct device *dev) |
Contributor
There was a problem hiding this comment.
Maybe call this is_can_and_ready?
Member
There was a problem hiding this comment.
I think the existing name is fine as this function may be extended to do further checks in the future.
martinjaeger
approved these changes
Dec 2, 2024
str4t0m
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wrapper DEVICE_API macro to all can_driver_api instances.