boards: samples: Add multicore support for NXP mcxn947. #81882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasGalbickaNXP
requested review from
dleach02 and
mmahadevan108
as code owners
zephyrbot
added
area: IPC
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
arnopo,
butok,
carlocaione,
danieldegrasse,
dbaluta,
decsny,
doki-nordic,
kartben,
manuargue,
nashif and
yvanderv
TomasGalbickaNXP
force-pushed
the
feature/mcxn94x-multicore-support
branch
2 times, most recently
from
d496856 to
3d99703
Compare
samples/drivers/mbox/remote/boards/frdm_mcxn947_mcxn947_cpu1.conf
Outdated
Show resolved
Hide resolved
Contributor
danieldegrasse
left a comment
danieldegrasse
left a comment
There was a problem hiding this comment.
This is great to see, thanks. I think we should split the commits here out a bit, here's a suggested set of commits:
- commit modifying MBOX and IPM drivers for MCX support, and adding the DTS entries for the MBOX peripheral
- commit adding support for booting the second core at the SOC level (IE the SYS_INIT routine)
- commit adding board definitions and CMake changes to the board to enable dual core support
- commit adding support for each dual core sample. We could also this into commits for each sample, but I don't really think that's needed.
samples/drivers/mbox_data/remote/boards/frdm_mcxn947_mcxn947_cpu1.conf
Outdated
Show resolved
Hide resolved
samples/subsys/ipc/ipc_service/static_vrings/remote/boards/frdm_mcxn947_mcxn947_cpu1.conf
Outdated
Show resolved
Hide resolved
samples/drivers/mbox/remote/boards/frdm_mcxn947_mcxn947_cpu1.conf
Outdated
Show resolved
Hide resolved
DerekSnell
requested changes
Nov 25, 2024
Contributor
DerekSnell
left a comment
DerekSnell
left a comment
There was a problem hiding this comment.
Hi @TomasGalbickaNXP ,
Building for cpu1 fails for me because of this typo in the hal_nxp: #enidf instead of #endif. It appears we also need to update the HAL to resolve this, and update the West manifest in your PR.
To replicate, I see this error building the hello_world sample with this command:
west build -b frdm_mcxn947//cpu1 samples/hello_world/ --pristine
The error:
/home/snellda/zNXPmicro/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MCXN947/system_MCXN947_cm33_core1.c: In function 'SystemInit':
/home/snellda/zNXPmicro/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MCXN947/system_MCXN947_cm33_core1.c:80: error: unterminated #if
80 | #if !defined(__ZEPHYR__)
|
/home/snellda/zNXPmicro/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MCXN947/system_MCXN947_cm33_core1.c:78:3: error: expected declaration or statement at end of input
78 | SYSCON->NVM_CTRL &= ~SYSCON_NVM_CTRL_DIS_MBECC_ERR_DATA_MASK; /* enables bus error on multi-bit ECC error for data */
I initially tried building the OpenAMP sample, and had the same error:
west build -b frdm_mcxn947//cpu0 --sysbuild samples/subsys/ipc/openamp --pristine
d327b5d to
fb3ba4c
Compare
Contributor
|
@TomasGalbickaNXP please rebase when you get a chance |
TomasGalbickaNXP
force-pushed
the
feature/mcxn94x-multicore-support
branch
from
fb3ba4c to
358c358
Compare
danieldegrasse
previously approved these changes
Dec 5, 2024
TomasGalbickaNXP
force-pushed
the
feature/mcxn94x-multicore-support
branch
from
358c358 to
0eb036f
Compare
decsny
requested changes
Dec 10, 2024
nordicjm
reviewed
Dec 11, 2024
samples/drivers/mbox_data/remote/boards/frdm_mcxn947_mcxn947_cpu1.overlay
Outdated
Show resolved
Hide resolved
samples/drivers/mbox/remote/boards/frdm_mcxn947_mcxn947_cpu1.overlay
Outdated
Show resolved
Hide resolved
TomasGalbickaNXP
force-pushed
the
feature/mcxn94x-multicore-support
branch
2 times, most recently
from
5cfc00c to
78f9f07
Compare
This commit adds MBOX device tree entry for MCXN947. Adds support for MCXN in NXP ipm and mbox drivers. Signed-off-by: Tomas Galbicka <[email protected]>
TomasGalbickaNXP
force-pushed
the
feature/mcxn94x-multicore-support
branch
2 times, most recently
from
b909825 to
01d726f
Compare
decsny
previously approved these changes
Dec 11, 2024
TomasGalbickaNXP
force-pushed
the
feature/mcxn94x-multicore-support
branch
from
01d726f to
19dbdb3
Compare
Member
|
see comment above about flash , I think still we should have minimal things enabled on cpu1 |
This commit adds multicore support for MCXN947. It enables the secondary core CPU1 to boot from flash. Signed-off-by: Tomas Galbicka <[email protected]>
This commit adds support for these multicore samples: - samples/drivers/mbox - samples/drivers/mbox_data - samples/subsys/ipc/ipc_service/static_vrings - samples/subsys/ipc/openamp Signed-off-by: Tomas Galbicka <[email protected]>
TomasGalbickaNXP
force-pushed
the
feature/mcxn94x-multicore-support
branch
from
19dbdb3 to
28d17e9
Compare
decsny
approved these changes
Dec 20, 2024
danieldegrasse
approved these changes
Jan 14, 2025
dleach02
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multicore support for frdm_mcxn947. The cpu1 is booted from flash.
Samples supported by this commit:
The frdm_mcxn947 supports the mbox driver.