drivers: video: Disable the driver if real camera presents #81725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josuah
approved these changes
Nov 21, 2024
Contributor
josuah
left a comment
josuah
left a comment
There was a problem hiding this comment.
This makes the software generator a default source that can be enabled by default by samples, since it goes a away when some board has a camera.
Great way to always make sure there is a "last resort" video source.
…sents Do not enable the video sw generator if a real camera is present. This helps to save some spaces and to avoid unrelated code going into the built image. Signed-off-by: Trung Hieu Le <[email protected]> Signed-off-by: Phi Bang Nguyen <[email protected]>
ngphibang
requested changes
Nov 21, 2024
Contributor
ngphibang
left a comment
ngphibang
left a comment
There was a problem hiding this comment.
Commit titile should be changed to "drivers: video: sw_generator: Disable the driver if a real camera presents" as this affects only the video sw generator driver"
trunghieulenxp
force-pushed
the
fix/optimize_video_sw_generator_compilation
branch
from
f397fe8 to
8319511
Compare
Contributor
Author
Hi, I have modified it. |
loicpoulain
approved these changes
Nov 22, 2024
ngphibang
approved these changes
Nov 22, 2024
kartben
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not enable the video sw generator if a real camera is present. This helps to save some spaces and to avoid unrelated code going into the built image.
If the real camera presents, there will be a warning which cannot be avoided:
`warning: VIDEO_SW_GENERATOR (defined at drivers/video/Kconfig.sw_generator:8) was assigned the value 'y' but got the value 'n'