Skip to content

Conversation

@brycewilkins
Copy link
Contributor

Kconfig options for RTT control block initialization and linker section were added in #53569, however the Zephyr west.yml was not updated to incorporate the Segger repository changes (zephyrproject-rtos/segger#17) required to make use of the new Kconfig options.

This fixes that by updating west.yml.

Segger repository changes by @giansta

@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Nov 15, 2024
@zephyrbot
Copy link

zephyrbot commented Nov 15, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
segger zephyrproject-rtos/segger@798f95e zephyrproject-rtos/segger@1a607e8 (master) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@brycewilkins
Copy link
Contributor Author

@nordicjm @carlescufi The PR #53569 is in v4.0.0 so it would be great to have the Segger PR (zephyrproject-rtos/segger#17) merged and the west.yml updated so this can all work together. Fingers crossed...

@nordicjm
Copy link
Contributor

Too late for 4.0, the release is today, but it can be merged to main after the release is finished and the 2 day review period has passed, and be in (early) for 4.1

nordicjm
nordicjm previously approved these changes Nov 15, 2024
@brycewilkins
Copy link
Contributor Author

brycewilkins commented Nov 15, 2024

Converted to draft; zephyrproject-rtos/segger#17 needs to be rebased to fix the build errors.

Update: rebased and now passing tests.

@brycewilkins brycewilkins marked this pull request as ready for review November 15, 2024 22:56
@cfriedt
Copy link
Member

cfriedt commented Nov 18, 2024

@brycewilkins - the module pr has been merged. Please update this PR to include the correct commit in west.yml

Kconfig options for RTT control block initialization and linker
section were added in zephyrproject-rtos#53569, however the Zephyr west.yml was not
updated to incorporate the Segger repository changes to make use
of the new Kconfig options.

This fixes that.

Signed-off-by: Bryce Wilkins <[email protected]>
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Nov 18, 2024
@nashif nashif merged commit dacc462 into zephyrproject-rtos:main Nov 19, 2024
25 of 26 checks passed
@brycewilkins brycewilkins deleted the bw/update_west_segger branch November 20, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manifest manifest-segger size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants