Npm2100 driver #79587
Merged
Npm2100 driver #79587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Sensors
zephyrbot
requested review from
MaureenHelm,
aasinclair,
avisconti,
danieldegrasse,
henrikbrixandersen,
jaz1-nordic,
katsuster,
kl-cruz,
magp-nordic,
martinjaeger,
masz-nordic,
mnkp and
nika-nordic
nordic-auko
force-pushed
the
npm2100_driver
branch
2 times, most recently
from
34c355b to
7541ac0
Compare
WalkingTalkingPotato
approved these changes
Oct 15, 2024
Member
|
@nordic-auko this needs a rebase. Your commits state "Initial driver for...". What does the "initial" mean? Is it still a draft or incomplete implementation? If not, I'd suggest to remove it to avoid any confusion. |
nordic-auko
force-pushed
the
npm2100_driver
branch
from
7541ac0 to
859d656
Compare
Contributor
Author
Rebased it now. |
nordic-auko
force-pushed
the
npm2100_driver
branch
2 times, most recently
from
53727c3 to
6f52da4
Compare
nordic-auko
force-pushed
the
npm2100_driver
branch
3 times, most recently
from
16ec5f5 to
07e8db3
Compare
martinjaeger
requested changes
Dec 2, 2024
Member
martinjaeger
left a comment
martinjaeger
left a comment
There was a problem hiding this comment.
Only reviewed the watchdog part, where I got a minor change request.
gmarull
reviewed
Dec 3, 2024
Member
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
good stuff, a few comments from my side.
nordic-auko
force-pushed
the
npm2100_driver
branch
2 times, most recently
from
3b7aad2 to
f636556
Compare
nordic-auko
force-pushed
the
npm2100_driver
branch
from
f636556 to
a2be7e6
Compare
Add mfd driver for the npm2100 pmic device. The driver contains basic initialization routines, and functionality not covered by other device driver APIs. Signed-off-by: Audun Korneliussen <[email protected]>
Add gpio driver for npm2100 pmic. Signed-off-by: Audun Korneliussen <[email protected]>
Add regulator driver for npm2100 pmic. This pmic has one boost and one ldo regulator. Signed-off-by: Audun Korneliussen <[email protected]>
Add sensor driver for npm2100 pmic. This pmic performs measurements of battery voltage, regulator voltage and die temperature. Configurable pmic attributes are also organized under this driver. Signed-off-by: Audun Korneliussen <[email protected]>
Add watchdog driver for npm2100 pmic. This pmic has one timer that can be used for multiple functions, including a watchdog that can reset or power-cycle connected devices. Signed-off-by: Audun Korneliussen <[email protected]>
nordic-auko
force-pushed
the
npm2100_driver
branch
from
a2be7e6 to
7e0cb3e
Compare
gmarull
approved these changes
Dec 4, 2024
martinjaeger
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add drivers for nPM2100 PMIC.
This is a multi-function device with regulators, gpio, watchdog, adc, and other supporting functions.