modules: segger: remove mutex locking #79404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
JordanYates
force-pushed
the
241004_rtt_locking
branch
2 times, most recently
from
e0b9343 to
fa5a9f4
Compare
JordanYates
force-pushed
the
241004_rtt_locking
branch
from
fa5a9f4 to
6115a0b
Compare
dcpleung
previously approved these changes
Oct 4, 2024
henrikbrixandersen
requested changes
Oct 7, 2024
modules/segger/SEGGER_RTT_zephyr.c
Outdated
There was a problem hiding this comment.
Is this mutex instance still used?
JordanYates
force-pushed
the
241004_rtt_locking
branch
from
6115a0b to
21e6ad1
Compare
JordanYates
force-pushed
the
241004_rtt_locking
branch
from
21e6ad1 to
49a50a3
Compare
henrikbrixandersen
previously approved these changes
Oct 8, 2024
nordic-krch
previously approved these changes
Oct 8, 2024
Remove mutex locking in favour of the standard IRQ locking mechanism. The primary problem with the mutex implementation is that mutex locking is forbidden in ISR's. This means that any logging from an interrupt context (e.g. LOG_PANIC in an exception handler), will itself trigger another assertion due its attempt to use a mutex. Furthermore, mutexes are a relatively heavyweight locking scheme, which doesn't necessarily make sense in the context of extremely short locking periods that would be expected from RTT. This change aligns Zephyr with the default RTT locking scheme, which uses interrupt masking to perform access control. Resolves zephyrproject-rtos#79403. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
dismissed stale reviews from nordic-krch and henrikbrixandersen
via
3ac4405
JordanYates
force-pushed
the
241004_rtt_locking
branch
from
49a50a3 to
3ac4405
Compare
|
Updated with final SHA |
henrikbrixandersen
approved these changes
Oct 8, 2024
nordic-krch
approved these changes
Oct 10, 2024
|
@dcpleung , can you help review |
dcpleung
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove mutex locking in favour of the standard IRQ locking mechanism. The primary problem with the mutex implementation is that mutex locking is forbidden in ISR's. This means that any logging from an interrupt context (e.g. LOG_PANIC in an exception handler), will itself trigger another assertion due its attempt to use a mutex.
Furthermore, mutexes are a relatively heavyweight locking scheme, which doesn't necessarily make sense in the context of extremely short locking periods that would be expected from RTT.
This change aligns Zephyr with the default RTT locking scheme, which uses interrupt masking to perform access control.
Resolves #79403.