Skip to content

NXP drivers: dma: dma_mcux_pxp: Add flip feature #76484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 7, 2024
Merged

NXP drivers: dma: dma_mcux_pxp: Add flip feature #76484

merged 5 commits into from
Aug 7, 2024

Conversation

@DerekSnell
Copy link
Contributor

@DerekSnell DerekSnell commented Jul 30, 2024

Update PXP driver to flip horizontally and/or vertically. Also updated display_mcux_elcdif driver to flip when writing to display. Tested with sample/subsys/video/capture.

@DerekSnell
boards: nxp: mimxrt1060_evkb: enable dvp_fpc24_mt9m114 shield
e8935a0 
Enable camera shield.  Tested with samples/subsys/video/capture.

Signed-off-by: Derek Snell <[email protected]>
@DerekSnell
boards: nxp: mimxrt1064_evk: enable PXP
4a0b39a 
Enable PXP in board devicetree for display samples.

Signed-off-by: Derek Snell <[email protected]>
@DerekSnell
drivers: dma: dma_mcux_pxp: Add flip feature
233f587 
PXP can flip an image in input buffer horizontally, vertically, or both.

Signed-off-by: Derek Snell <[email protected]>
@DerekSnell
drivers: display: display_mcux_elcdif: Add PXP flip feature
0859b8e 
display_write() can leverage PXP to flip the image.

Signed-off-by: Derek Snell <[email protected]>
@DerekSnell
samples: video: capture: leverage PXP to flip image
5c0fc87 
PXP can flip image written to the frame buffer.  Provide a mirror image
on the display by flipping the camera image horizontally.  Enabled on
boards mimxrt1066_evk and mimxrt1060_evkb.

Signed-off-by: Derek Snell <[email protected]>
@zephyrbot zephyrbot added platform: NXP Drivers NXP Semiconductors, drivers area: Display area: DMA Direct Memory Access area: Shields Shields (add-on boards) platform: NXP NXP area: Samples Samples labels Jul 30, 2024
@DerekSnell DerekSnell removed the area: Shields Shields (add-on boards) label Jul 30, 2024
@nashif nashif merged commit 3226d10 into zephyrproject-rtos:main Aug 7, 2024
@DerekSnell DerekSnell deleted the feature/pxp_horizontal_flip branch August 7, 2024 15:56
@kartben
Copy link
Contributor

kartben commented Aug 15, 2024

#73001 was merged before this one. Please resubmit, @DerekSnell, as the files are now in the wrong folder

@DerekSnell
Copy link
Contributor Author

DerekSnell commented Aug 16, 2024

#73001 was merged before this one. Please resubmit, @DerekSnell, as the files are now in the wrong folder

Will do, thanks for making me aware.

@ngphibang
Copy link
Contributor

ngphibang commented Aug 20, 2024 •
edited
Loading

@DerekSnell : The video capture sample has been moved from sample/subsys/video/capture to sample/drivers/video/capture. I don't understand why you still let the board configs files (1064 and 1060 evk) in /subsys and not place them in /drivers ? Does it really work when the configs and the sample code are in two different places ?

@DerekSnell
Copy link
Contributor Author

DerekSnell commented Aug 20, 2024

Hi @ngphibang ,
No, it won't work, and this was not intentional. As kartben stated above, #73001 merged 2 days before this PR, and moved that sample. Now we need a new PR to move these files.

Best regards

@josuah josuah mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdgendt pdgendt pdgendt approved these changes

@dleach02 dleach02 dleach02 approved these changes

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@avisconti avisconti Awaiting requested review from avisconti

@butok butok Awaiting requested review from butok

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@dbaluta dbaluta Awaiting requested review from dbaluta

@decsny decsny Awaiting requested review from decsny

@EmilioCBen EmilioCBen Awaiting requested review from EmilioCBen

@erwango erwango Awaiting requested review from erwango

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@kartben kartben Awaiting requested review from kartben

@manuargue manuargue Awaiting requested review from manuargue

@nashif nashif Awaiting requested review from nashif

@teburd teburd Awaiting requested review from teburd

@yvanderv yvanderv Awaiting requested review from yvanderv

Assignees

@dleach02 dleach02

Labels

area: Display area: DMA Direct Memory Access area: Samples Samples platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@DerekSnell @kartben @ngphibang @pdgendt @dleach02 @nashif @zephyrbot