posix: add stubs for signal.h functions that need process support #76327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
posix-signals-stubs
branch
5 times, most recently
from
dc56ff3 to
3453432
Compare
cfriedt
force-pushed
the
posix-signals-stubs
branch
6 times, most recently
from
f313cd3 to
14dda60
Compare
|
Rebased a bunch of times while CI was having issues. |
zephyrbot
requested review from
aescolar,
keith-packard,
nashif and
stephanosio
ycsin
previously approved these changes
Aug 3, 2024
|
@ceolin - feel like a re-review? This is mostly the same as the previous PR, just rebased. |
ceolin
previously approved these changes
Aug 6, 2024
cfriedt
force-pushed
the
posix-signals-stubs
branch
from
14dda60 to
5656515
Compare
zephyrbot
added
area: Coding Guidelines
zephyrbot
requested review from
carlescufi,
fabiobaltieri,
jfischer-no,
kartben,
keith-zephyr and
simhein
ycsin
previously approved these changes
Aug 15, 2024
cfriedt
force-pushed
the
posix-signals-stubs
branch
from
5656515 to
f5d27a4
Compare
|
This PR now includes a commit from #77104, to mitigate false-positive Coding Guideline checks. That PR should preferably be merged before this. |
Newlib requires an alias for the getpid() function. There was a Kconfig already present for doing so, but the actual alias was missing. So this is technically a bugfix. Signed-off-by: Chris Friedt <[email protected]>
Since Zephyr itself does not currently support processes, but conformant applications should still be able to link, add stubs for the remaining POSIX functions in the POSIX_SIGNALS Option Group. The POSIX_SIGNALS Option Group is required for PSE51, PSE52, PSE53, PSE54, and likely many other POSIX Subprofiles. Signed-off-by: Chris Friedt <[email protected]>
Add tests for the presence of items in the POSIX SIGNALS Option Group. Signed-off-by: Chris Friedt <[email protected]>
Mark the POSIX_SIGNALS Option Group as supported to the extent possible under Zephyr, as Zephyr does not yet support processes. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
posix-signals-stubs
branch
from
f5d27a4 to
3136e42
Compare
ycsin
approved these changes
Aug 21, 2024
ceolin
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmission of #74436.
There seems to have been an oversight in #75244 in that these commits (belonging neither to #73978 nor #74096) were reverted. No justification was made for PR #74436 to be reverted, so presumably it was an accident.
Indeed, all testing passed with this PR in
mainas well as against thev3.7.0tag. Also ran through CI successfully with the expanded testing in #76377.Since Zephyr itself does not currently support processes, but conformant applications should still be able to link, add stubs for the remaining POSIX functions in the
POSIX_SIGNALSOption Group.The
POSIX_SIGNALSOption Group is required for PSE51, PSE52, PSE53, PSE54, and likely many other POSIX Subprofiles.Doc Preview
Fixes #59925
Fixes #59933
Fixes #66923
Fixes #66924
Fixes #66925
Fixes #66929
Fixes #66930