boards: nxp: mimxrt1064: Remove display chosen node #74227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As display stuffs have been moved to a shield, the display chosen node must be removed as well as chosen node requires the node to be enabled. Signed-off-by: Phi Bang Nguyen <[email protected]>
zephyrbot
added
platform: NXP
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
butok,
danieldegrasse,
decsny,
dleach02,
mmahadevan108 and
yvanderv
This was referenced Jun 13, 2024
Contributor
Author
|
To be able to detect similar issues in the future, I think the device tree scripts should have a mechanism to check on the zephyr chosen nodes and generate an error at compile time if a node is disabled ? I can look into this if you want. |
Member
no |
danieldegrasse
approved these changes
Jun 13, 2024
Contributor
danieldegrasse
left a comment
danieldegrasse
left a comment
There was a problem hiding this comment.
Apologies for missing this!
decsny
approved these changes
Jun 13, 2024
decsny
added
the
Trivial
dleach02
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As display stuffs have been moved to a shield, the display chosen node must be removed as well because chosen node requires the node to be enabled. This causes CI failure for #72633