-
Notifications
You must be signed in to change notification settings - Fork 8.2k
boards: frdm_mcxn947: Add clock setup for FlexSPI #71621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: frdm_mcxn947: Add clock setup for FlexSPI #71621
Conversation
decsny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which memc driver are you talking about? it should be clarified in the commit message first of all, and need to know if we need to find a better solution if this problem will occur generally
Is the issue here that the FlexSPI was previously not being clocked prior to memc init, causing a hang? If so, I think this solution generally follows the pattern we are currently using for other peripheral clocking |
37dba62 to
1e4886c
Compare
Commit message updated to include the memc driver details. |
Yes. FlexSPI clock is left un initialized at boot time causing a hang. |
The commit message should also say what the "flexspi driver" is, as there are multiple flexspi drivers just like there are multiple memc drivers. |
1e4886c to
ff3639a
Compare
|
@decsny, kindly re-review |
|
I still think this should not have to be done in board code but don't know the complications so not blocking it right now |
|
@dleach02, can you please review and approve |
The MEMC driver in memc_mcux_flexspi.c is initialized before the FlexSPI driver (flash_mcux_flexspi_nor.c) and hangs during FlexSPI init. Initialize the FlexSPI clock to 50MHz before the speed is set to the optimum speed by the FlexSPI driver. Signed-off-by: Mahesh Mahadevan <[email protected]>
55eec94
ff3639a to
55eec94
Compare
decsny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reapprove
henrikbrixandersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it this (board.c used for clock setup) is an interim solution until we have something like #70467 available?
The MEMC driver is initialized before the FlexSPI driver and hangs during FlexSPI init. Initialize the FlexSPI clock to 50MHz before the speed is set to the optimum speed by the FlexSPI driver.