- 
                Notifications
    You must be signed in to change notification settings 
- Fork 8.2k
samples: drivers: video: add capture to lvgl sample #71463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: drivers: video: add capture to lvgl sample #71463
Conversation
| This sample has been tested on the mini_stm32h743 target with the OV2640 camera model. It depends on the PR #71462. Should I move this sample to board-specific samples folder? 
 This version works with "VIDEO_SW_GENERATOR" 
 and with shield #77949. 
 Thanks! document_4958923842157282345.mp4 | 
2ef83aa    to
    6d4059d      
    Compare
  
    | Fix compliance check errors. The error "Found references to undefined Kconfig symbols" happened because this PR depend on the PR #71462 | 
5c3a8bf    to
    e3c5082      
    Compare
  
    | Fix image alignment document_4972170831263171749.mp4 | 
e3c5082    to
    b4accd6      
    Compare
  
    | git rebase | 
b4accd6    to
    459670f      
    Compare
  
    | Add the clock rate control property. This property depend on #71962 | 
459670f    to
    72cae10      
    Compare
  
    | Remove shell device, increase main stack size, and change the video buffer array from 1 to 2. | 
82464f5    to
    aebab04      
    Compare
  
    aebab04    to
    9b21fef      
    Compare
  
            
          
                samples/subsys/video/capture_to_lcd/boards/mini_stm32h743.overlay
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | As I understand it, with the LVGL addition, this makes it closer to a demo (showing most of the capabilities of a system) than a sample code (minimal code to implement a single feature). Is LVGL required for the video to display flow to work? | 
| 
 Unfortunately, no! The shield PR is still open. I just removed it from the PR dependency list above. | 
b91521a    to
    24b6622      
    Compare
  
    | 
 | 
| The CI passed now! Thanks for the tip, @josuah! :-) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one last reference to something that is just about to be merged :shield: weact_ministm32h7xx_ov2640.
The rest all looks like being ready.
Some config like CONFIG_VIDEO_HFLIP or DT_HAS_CHOSEN(zephyr_camera) are not used by this example, but were still tested against a custom shield (being submitted), so are known to work, and can be used by anyone integrating their own shield in the future.
This currently works with the test pattern generator.
        
          
                samples/drivers/video/capture_to_lvgl/boards/mini_stm32h743.conf
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                samples/drivers/video/capture_to_lvgl/boards/mini_stm32h743.overlay
              
                Outdated
          
            Show resolved
            Hide resolved
        
      24b6622    to
    b222f27      
    Compare
  
    | Rebase. | 
b222f27    to
    0aa5882      
    Compare
  
    | Update the samples.yaml by adding the  | 
0aa5882    to
    008914f      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very minimal now. Easy to use as a starting point for graphics + video.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be much shorter and written as id completing the sentence "this sample shows how to..."
| This sample application demonstrates how to use the video API to retrieve video | |
| frames from a capture device and display them on an LCD via the LVGL library. | |
| Capture video frames and display them on an LCD using LVGL. | 
Will be much more consistent with other samples, too: https://builds.zephyrproject.io/zephyr/pr/71463/docs/samples/drivers/video/video.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| a video capture device, writes a frame count message to the console, and then sends | |
| the frame to an LCD display. | |
| a video capture device, write a frame count message to the console, and then send | |
| the frame to an LCD display. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Add sample application to capture an image frame from a camera and send it for display on LCD via the LVGL library. Signed-off-by: Charles Dias <[email protected]>
008914f    to
    d823ee6      
    Compare
  
    | Implemented @kartben suggestions. | 
Add sample application to capture an image frame from a camera and send it for display on the LCD.
This PR depends on: