Add LCD Support on NXP MCXN947 over FlexIO #71406

mmahadevan108 · 2024-04-11T19:37:27Z

This PR enables FlexIO support and adds support for the LCD-PAR-S035 NXP display over the FlexIO.

Depends on #70583 for some updates to the MIPI DBI implementation

zephyrbot · 2024-04-11T19:44:47Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

mmahadevan108 · 2024-04-12T19:53:55Z

cc @jasonNXP

zejiang0jason · 2024-05-16T02:06:29Z

boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi

Is there plan to support 8-bit data width? if yes, then need to define a macro FLEXIO_MCULCD_DATA_BUS_WIDTH:
https://github.com/zephyrproject-rtos/hal_nxp/blob/abc66979c77421fb3a140ce2e4e6ea7165cdbe8f/mcux/mcux-sdk/drivers/flexio/mculcd/fsl_flexio_mculcd.h#L44C1-L49C3

Yes, this is passed as a compile time MACRO via the CMake file. I have added a change request to the SDK driver to avoid using this macro as it has limitations. Please see my change request for details

danieldegrasse · 2024-05-20T14:33:48Z

dts/bindings/mipi-dbi/mipi-dbi-controller.yaml

I think rather than adding the data bus property to the display, we should define multiple MIPI modes for each data bus width. Something like the following:

#define MIPI_DBI_MODE_8080_BUS_16_BIT 0x4 #define MIPI_DBI_MODE_8080_BUS_9_BIT 0x5 #define MIPI_DBI_MODE_8080_BUS_8_BIT 0x6

I see two benefits to this:

avoid duplication of bus width encoding in each display driver (I suspect this problem won't be unique to the ST7796S)

allow MIPI DBI drivers to reconfigure their bus width at runtime (I'm aware that due to the SDK driver structure this won't work for FlexIO, but I suspect most hardware will support runtime reconfiguration like this)

@danieldegrasse, I have made this change.

Add support to get FlexIO clock Signed-off-by: Mahesh Mahadevan <[email protected]>

Add defines for MIPI DBI Type A based on Motorola 6800 and Type B baedon Intel 8080 bus Signed-off-by: Mahesh Mahadevan <[email protected]>

drivers/display/display_st7796s.c

danieldegrasse · 2024-06-12T17:14:02Z

dts/bindings/display/sitronix,st7796s.yaml

Do we still need support for the rgb-is-inverted property given the discussion here? Or can it be dropped?

If we have a use case I think adding support for this makes sense, but otherwise I would lean towards removing it to minimize the size of the driver

danieldegrasse · 2024-06-12T17:15:42Z

drivers/mipi_dbi/CMakeLists.txt

Wouldn't data_bus_width being 8 indicate 16 bit mode?

This is looking at the values in the mipi_dbi.h file.

Yes, but in both cases (data_bus_width==8 or data_bus_width==5) we are setting the FLEXIO bus width to 8. Is this correct, or should we set it to 16 when data_bus_width==8?

Yes, this is accurate. One for 8080 and one for 6800

After some offline discussion, I understand this better now- the SDK driver will default to 16 bits if no value is set for this variable. The enum values 5 and 8 correspond to MIPI DBI 8 bit mode for 6800 and 8080. Since the SDK defaults to 16 bit mode, no else statement is needed here to set the definition in that case

danieldegrasse · 2024-06-12T17:17:35Z

drivers/mipi_dbi/mipi_dbi_nxp_flexio_lcdif.c

We should probably add an additional check here to see if the requested MIPI mode is 8 bit when the driver is configured for 16 bit (or vice versa for 16 bit mode). Not sure if we need this though, since the CMake logic should identify the correct MIPI DBI setting based on the chosen display

Thats right, the SDK driver configuration is picked from device tree.

MIPI mode is read from the device tree. Signed-off-by: Mahesh Mahadevan <[email protected]>

1. Add a property for panels where the RGB is displayed as BGR. 2. Add a check for 8080 8-bit mode and invert RGB and BGR for this case. Signed-off-by: Mahesh Mahadevan <[email protected]>

Add a driver to support the NXP FlexIO LCD controller that uses 8080/6800 bus protocol. Signed-off-by: Mahesh Mahadevan <[email protected]>

NXP LCD-PAR-S035 LCD module will be used by FRDM-X evaluation kits with a parallel LCD connector. Signed-off-by: Mahesh Mahadevan <[email protected]>

Add support for the LCD-PAR-S035 display over the FlexIO interface. Signed-off-by: Mahesh Mahadevan <[email protected]>

decsny · 2024-06-13T18:09:52Z

dts/bindings/mipi-dbi/nxp,mipi-dbi-flexio-lcdif.yaml

+    type: phandle-array
+    required: true
+    description: |
+      RS Pin


what does RS stand for

decsny · 2024-06-13T18:10:13Z

dts/bindings/mipi-dbi/nxp,mipi-dbi-flexio-lcdif.yaml

+    required: true
+    description: |
+      CS Pin
+      GPIO to drive the CS pin.


what does CS stand for (probably chip select?) should put this in description

mmahadevan108 requested a review from dleach02 as a code owner April 11, 2024 19:37

zephyrbot added platform: NXP NXP area: Devicetree Binding PR modifies or adds a Device Tree binding area: Clock Control platform: NXP Drivers NXP Semiconductors, drivers area: Display area: Display Controller area: Shields Shields (add-on boards) labels Apr 11, 2024

zephyrbot requested review from DerekSnell, EmilioCBen, avisconti, danieldegrasse, dbaluta, decsny, erwango, galak, jfischer-no, kartben, manuargue, nordic-krch and yvanderv April 11, 2024 19:38

zephyrbot assigned danieldegrasse Apr 11, 2024

mmahadevan108 force-pushed the Add_MCX_LCD branch from 1ab6c1b to 0dbc805 Compare April 11, 2024 19:43

zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Apr 11, 2024

mmahadevan108 force-pushed the Add_MCX_LCD branch 2 times, most recently from d7e3b36 to f70a6df Compare April 11, 2024 20:27

mmahadevan108 force-pushed the Add_MCX_LCD branch from 7dee2be to 17a0078 Compare May 15, 2024 17:40

mmahadevan108 requested review from danieldegrasse, decsny and groncarolo May 15, 2024 17:40

zejiang0jason reviewed May 16, 2024

View reviewed changes

zejiang0jason mentioned this pull request May 16, 2024

dts: mcxn947: Fix input key error #72889

Merged

mmahadevan108 force-pushed the Add_MCX_LCD branch from 17a0078 to 3a8febe Compare May 17, 2024 22:35

zephyrbot removed manifest manifest-hal_nxp labels May 17, 2024

mmahadevan108 requested a review from zejiang0jason May 17, 2024 22:36

mmahadevan108 force-pushed the Add_MCX_LCD branch from 3a8febe to 53389e0 Compare May 17, 2024 22:39

danieldegrasse reviewed May 20, 2024

View reviewed changes

mmahadevan108 added 2 commits June 11, 2024 19:07

drivers: clock_control: Update NXP LPC Syscon driver to add FlexIO

32eadd8

Add support to get FlexIO clock Signed-off-by: Mahesh Mahadevan <[email protected]>

include: mipi_dbi: Add defines for MIPI Type A and B

fb2727f

Add defines for MIPI DBI Type A based on Motorola 6800 and Type B baedon Intel 8080 bus Signed-off-by: Mahesh Mahadevan <[email protected]>

mmahadevan108 force-pushed the Add_MCX_LCD branch from 53389e0 to e948187 Compare June 12, 2024 16:52

danieldegrasse reviewed Jun 12, 2024

View reviewed changes

mmahadevan108 added 5 commits June 12, 2024 13:08

drivers: display: Update setting the mode in the st7796s driver

bdef74b

MIPI mode is read from the device tree. Signed-off-by: Mahesh Mahadevan <[email protected]>

drivers: display: st7796: Update the logic to invert RGB and BGR

33c0c2b

1. Add a property for panels where the RGB is displayed as BGR. 2. Add a check for 8080 8-bit mode and invert RGB and BGR for this case. Signed-off-by: Mahesh Mahadevan <[email protected]>

drivers: mipi_dbi: Add controller driver for NXP FlexIO LCD

b49927c

Add a driver to support the NXP FlexIO LCD controller that uses 8080/6800 bus protocol. Signed-off-by: Mahesh Mahadevan <[email protected]>

boards: shield: Add a shield for the NXP LCD-PAR-S035 LCD module

bed7eff

NXP LCD-PAR-S035 LCD module will be used by FRDM-X evaluation kits with a parallel LCD connector. Signed-off-by: Mahesh Mahadevan <[email protected]>

boards: frdm_mcxn947: Add Display support

0953fc1

Add support for the LCD-PAR-S035 display over the FlexIO interface. Signed-off-by: Mahesh Mahadevan <[email protected]>

mmahadevan108 force-pushed the Add_MCX_LCD branch from e948187 to 0953fc1 Compare June 12, 2024 18:08

mmahadevan108 added this to the v3.7.0 milestone Jun 12, 2024

danieldegrasse approved these changes Jun 13, 2024

View reviewed changes

decsny reviewed Jun 13, 2024

View reviewed changes

dts/bindings/mipi-dbi/nxp,mipi-dbi-flexio-lcdif.yaml

type: phandle-array

required: true

description: |

RS Pin

Copy link

Member

decsny Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does RS stand for

decsny reviewed Jun 13, 2024

View reviewed changes

decsny approved these changes Jun 13, 2024

View reviewed changes

nashif merged commit b2d1e45 into zephyrproject-rtos:main Jun 13, 2024

mmahadevan108 deleted the Add_MCX_LCD branch June 17, 2024 21:12

danieldegrasse mentioned this pull request Oct 18, 2024

Fix rgb565 / bgr565 interchange issue in Zephyr display #79996

Merged

Uh oh!

Add LCD Support on NXP MCXN947 over FlexIO #71406

Add LCD Support on NXP MCXN947 over FlexIO #71406

Uh oh!

Conversation

mmahadevan108 commented Apr 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zephyrbot commented Apr 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmahadevan108 commented Apr 12, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mmahadevan108 Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mmahadevan108 commented Apr 11, 2024 •

edited

Loading

zephyrbot commented Apr 11, 2024 •

edited

Loading

mmahadevan108 Jun 13, 2024 •

edited

Loading