Skip to content

Conversation

@ene-steven
Copy link
Contributor

@ene-steven ene-steven commented Oct 20, 2023

@zephyrbot zephyrbot added area: UART Universal Asynchronous Receiver-Transmitter area: GPIO area: Pinctrl area: Devicetree Binding PR modifies or adds a Device Tree binding area: I2C labels Oct 20, 2023
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please split into meaningful commits, see https://docs.zephyrproject.org/latest/contribute/guidelines.html

@ene-steven
Copy link
Contributor Author

please split into meaningful commits, see https://docs.zephyrproject.org/latest/contribute/guidelines.html

KB1200 is a new chip, there is no code on zephyrproject.
I've minimized the code that can be built and run on the EVB board.
I don't know how to split into meaningful commits.

@ycsin
Copy link
Member

ycsin commented Oct 30, 2023

I don't know how to split into meaningful commits.

Thanks for this PR. You can probably consider splitting the commit into:

  1. Devicetree bindings
  2. SoC
  3. Board
  4. Drivers (gpio, i2c, spi, ...)

Please have a look at #56370.

Lastly, the current commit title doesn't conform to Zephyr contribution guidelines (this will fail in the GitHub CI test), you will also need to provide meaningful commit message about this change, please see https://docs.zephyrproject.org/latest/contribute/guidelines.html

Copy link
Member

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some of the obvious ones

@ycsin
Copy link
Member

ycsin commented Oct 31, 2023

The title should be something like:

drivers: pinctrl: pinctrl device driver for ENE KB1200

you do not need those squared brackets.

Personally I wouldn't repeat the 'pinctrl' twice:

drivers: pinctrl: initial device driver for ENE KB1200

@ene-steven ene-steven requested a review from ycsin October 31, 2023 07:04
A new pwm controller addition

Signed-off-by: Steven Chang <[email protected]>
Add pwm device nodes and pinctrl nodes for ENE KB1200

Signed-off-by: Steven Chang <[email protected]>
Add pwm driver for ENE KB1200

Signed-off-by: Steven Chang <[email protected]>
A new tach controller addition

Signed-off-by: Steven Chang <[email protected]>
Add tach device nodes and pinctrl nodes for ENE KB1200

Signed-off-by: Steven Chang <[email protected]>
Add tachmeter driver for ENE KB1200

Signed-off-by: Steven Chang <[email protected]>
A new watchdog controller addition

Signed-off-by: Steven Chang <[email protected]>
Add watchdog device nodes and pinctrl nodes for ENE KB1200

Signed-off-by: Steven Chang <[email protected]>
Add watchdog driver for ENE KB1200

Signed-off-by: Steven Chang <[email protected]>
A new i2c controller addition

Signed-off-by: Steven Chang <[email protected]>
Add i2c device nodes and pinctrl nodes for ENE KB1200

Signed-off-by: Steven Chang <[email protected]>
Add i2c driver for ENE KB1200

Signed-off-by: Steven Chang <[email protected]>
Add owner to CODEOWNERS

Signed-off-by: Steven Chang <[email protected]>
Add support for ENE kb1200_evb board

Signed-off-by: Steven Chang <[email protected]>
@ene-steven ene-steven dismissed stale reviews from fabiobaltieri and gmarull via 06d951b March 15, 2024 03:15
@nordicjm nordicjm removed their request for review March 15, 2024 06:13
@fabiobaltieri fabiobaltieri merged commit 3a5bbb1 into zephyrproject-rtos:main Mar 15, 2024
@github-actions
Copy link

Hi @ene-steven!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@carlescufi
Copy link
Member

@ene-steven thank you for your patience and perseverance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ADC Analog-to-Digital Converter (ADC) area: Devicetree Binding PR modifies or adds a Device Tree binding area: GPIO area: I2C area: Pinctrl area: PWM Pulse Width Modulation area: Sensors Sensors area: UART Universal Asynchronous Receiver-Transmitter area: Watchdog Watchdog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants