-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Add ENE KB1200 SOC #64161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ENE KB1200 SOC #64161
Conversation
gmarull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please split into meaningful commits, see https://docs.zephyrproject.org/latest/contribute/guidelines.html
c7bc641 to
560f9f6
Compare
560f9f6 to
1fac5ed
Compare
KB1200 is a new chip, there is no code on zephyrproject. |
8a88dba to
27b365f
Compare
Thanks for this PR. You can probably consider splitting the commit into:
Please have a look at #56370. Lastly, the current commit title doesn't conform to Zephyr contribution guidelines (this will fail in the GitHub CI test), you will also need to provide meaningful commit message about this change, please see https://docs.zephyrproject.org/latest/contribute/guidelines.html |
ycsin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some of the obvious ones
27b365f to
0ff3348
Compare
|
The title should be something like: you do not need those squared brackets. Personally I wouldn't repeat the 'pinctrl' twice: |
A new pwm controller addition Signed-off-by: Steven Chang <[email protected]>
Add pwm device nodes and pinctrl nodes for ENE KB1200 Signed-off-by: Steven Chang <[email protected]>
Add pwm driver for ENE KB1200 Signed-off-by: Steven Chang <[email protected]>
A new tach controller addition Signed-off-by: Steven Chang <[email protected]>
Add tach device nodes and pinctrl nodes for ENE KB1200 Signed-off-by: Steven Chang <[email protected]>
Add tachmeter driver for ENE KB1200 Signed-off-by: Steven Chang <[email protected]>
A new watchdog controller addition Signed-off-by: Steven Chang <[email protected]>
Add watchdog device nodes and pinctrl nodes for ENE KB1200 Signed-off-by: Steven Chang <[email protected]>
Add watchdog driver for ENE KB1200 Signed-off-by: Steven Chang <[email protected]>
A new i2c controller addition Signed-off-by: Steven Chang <[email protected]>
Add i2c device nodes and pinctrl nodes for ENE KB1200 Signed-off-by: Steven Chang <[email protected]>
Add i2c driver for ENE KB1200 Signed-off-by: Steven Chang <[email protected]>
Add owner to CODEOWNERS Signed-off-by: Steven Chang <[email protected]>
Add support for ENE kb1200_evb board Signed-off-by: Steven Chang <[email protected]>
ed8c6b5 to
06d951b
Compare
|
Hi @ene-steven! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
|
@ene-steven thank you for your patience and perseverance. |
ene_kb1200_evb Zephyr doc preview