net/if: Do not start TX thread if there is no network interface #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And print a warning if that happens. This will also avoid to raise an ASSERT on net_if_tx_thread()'s k_poll as this one will be called with no events to work with. Signed-off-by: Tomasz Bursztyka <[email protected]>
nashif
added
the
In progress
|
btw, in commit subject you could shorten it to just "net/if" or "net: if:" |
jukkar
approved these changes
May 3, 2017
|
There's also an issue that if networking is enabled, but there's no networking interface, the boot process hangs (w/o any messages). Looking into that is in my long todo. I'm not sure if this patch helps with that, I guess not. |
tbursztyka
changed the title
|
@pfalcon : Hum, never experienced the issue and the tests that do not enable any net_if always boot and run properly (with or without this patch, besides the fact that ASSERT was screaming on k_poll). In which condition do you get this? |
|
@tbursztyka : This happens for BOARD=96b_carbon, was reported and confirmed with MicroPython Zephyr port. I now opened https://jira.zephyrproject.org/browse/ZEP-2105 |
nashif
approved these changes
May 3, 2017
nashif
removed
the
In progress
nagineni
pushed a commit
to nagineni/zephyr
that referenced
this pull request
Nov 20, 2017
[General] Update toplevel README to describe make instead of jsrunner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And print a warning if that happens.
This will also avoid to raise an ASSERT on net_if_tx_thread()'s k_poll
as this one will be called with no events to work with.
Signed-off-by: Tomasz Bursztyka [email protected]