BT mesh: Rename shadow variables #61733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aescolar
added
Hotfix
aescolar
requested review from
LingaoM,
PavelVPV,
Vudentz and
jhedberg
as code owners
PavelVPV
previously approved these changes
Aug 22, 2023
alxelax
previously requested changes
Aug 22, 2023
Contributor
alxelax
left a comment
alxelax
left a comment
There was a problem hiding this comment.
It would be mature if the same problem is solved on the same manner.
https://github.com/zephyrproject-rtos/zephyr/pull/61236/files#diff-9d35bfa2dc44279fbf0687382de4544e5ad427635016a5e5e80d77e546aa4fdfR34
It is better to rename global variable name here: https://github.com/zephyrproject-rtos/zephyr/pull/61733/files#diff-7584275c2da52cbcbe4efe8ca02fc9baacb02197f8db59677e8fc8828b0d1fbfL46
to dh_pair.
It should solve problem on the correct manner.
PavelVPV
approved these changes
Aug 22, 2023
Rename shadow variables found by -Wshadow After e38fc6d was merged, this cause CI failures. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Thalley
approved these changes
Aug 22, 2023
Member
Author
|
Twister failure due to related #61736 , just merged. |
alxelax
approved these changes
Aug 22, 2023
carlescufi
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename shadow variables found by -Wshadow
After e38fc6d
was merged, this cause CI failures.
Here a CI failure https://github.com/zephyrproject-rtos/zephyr/actions/runs/5937447483/job/16099892902?pr=60711#step:12:910
Fixes #61734