Fix selection process of net app server context #6073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When net_app_ctx has multiple net_contexts, selecting net_context
based on dst address has some glitches.
E.g. One net_app_ctx and two net_contexts (net_ctx1, net_ctx2).
Both net_contexts are mapped to net_app_ctx.
When a caller looking for net_ctx (e.g. net_ctx2) with
matching dst address. Loop goes through net_ctx1 and dst
doesn't match. But another if condition checks does this
net_context mapped to net_app_ctx, yes it matches.
So return net_ctx1, which is wrong.
So first go through all elements in array of net_contexts for
matching dst address, if it fails to find then go for matching
net_app_ctx.
Signed-off-by: Ravi kumar Veeramally <[email protected]>
Added a new API to get net pkt based on dst address. Destination address will be used to find correct net_context. Signed-off-by: Ravi kumar Veeramally <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #6073 +/- ##
==========================================
- Coverage 52.63% 52.62% -0.01%
==========================================
Files 410 410
Lines 40048 40060 +12
Branches 7781 7784 +3
==========================================
+ Hits 21078 21081 +3
- Misses 15768 15776 +8
- Partials 3202 3203 +1
Continue to review full report at Codecov.
|
Contributor
|
No concerns from my side, by I guess only @jukkar can say if this is the change in the right direction. |
jukkar
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When net_app_ctx has multiple net_contexts, selecting net_context based on dst address has some glitches. PR provides fixes and extra API for it.