-
Notifications
You must be signed in to change notification settings - Fork 8.1k
crypto: mbedtls: Update mbedTLS to 2.7.0 #6033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6033 +/- ##
==========================================
- Coverage 52.51% 52.34% -0.17%
==========================================
Files 406 406
Lines 39683 39795 +112
Branches 7715 7776 +61
==========================================
- Hits 20839 20832 -7
- Misses 15663 15759 +96
- Partials 3181 3204 +23
Continue to review full report at Codecov.
|
you need to update the README ext/lib/crypto/mbedtls/README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to updating the README file, please also shorten the link in the commit message: it's apparently too long for the bots to like it.
hmm, i thought i had an exception for long URLs... need to look |
fixed in #6034 |
Due to a security advisory released on February 1st 2018[1], it's advisable to update mbedTLS to 2.7.0. The vulnerability, identified as CVE-2018-0488 and CVE-2018-0487, risk remote code execution when truncated HMAC is enabled or when verifying RSASSA-PSS signatures. [1] https://tls.mbed.org/tech-updates/security-advisories/mbedtls-security-advisory-2018-01 Fixes: zephyrproject-rtos#6025 Signed-off-by: Kumar Gala <[email protected]>
|
README updated, leaving URL alone - pending fix from Anas getting in. |
|
Regarding URL shorteners, here's a recent (and pretty usual) case. I found an alleged data loss issue in mbedTLS, and researching it, saw it was "fixed" and, the the fix reverted then: Mbed-TLS/mbedtls@1fd00bf , Mbed-TLS/mbedtls@887bd50 . Maybe if the PolarSSL guys had that CI hook for requiring the full description in the commit message, there would be more information than reference to "ticket #18" in long-gone tracker. Likewise, if we don't try to workaround false positives with URL shorteners, maybe future developers will be able to understand our commit messages better. (Yes, the original URL may be gone too, but a URL like https://tls.mbed.org/tech-updates/security-advisories/mbedtls-security-advisory-2018-01 certainly conveys more info than https://shrt.me/fOobAR). So, thanks for going to fix that check! |
|
recheck |
Due to a security advisory released on February 1st 2018[1], it's
advisable to update mbedTLS to 2.7.0.
The vulnerability, identified as CVE-2018-0488 and CVE-2018-0487, risk
remote code execution when truncated HMAC is enabled or when verifying
RSASSA-PSS signatures.
[1] https://tls.mbed.org/tech-updates/security-advisories/mbedtls-security-advisory-2018-01
Fixes: #6025
Signed-off-by: Kumar Gala [email protected]