net: add winc1500 driver from Atmel #60
Conversation
drivers/wifi/Kconfig
Outdated
There was a problem hiding this comment.
change this into a menuconfig WIFI directly
drivers/wifi/Kconfig
Outdated
There was a problem hiding this comment.
and you can avoid the prompt by doing: bool "Add support for WiFi drivers"
drivers/wifi/Kconfig
Outdated
There was a problem hiding this comment.
and then here you would do:
if WIFI
drivers/wifi/Kconfig
Outdated
There was a problem hiding this comment.
and here, instead of endmenu:
endif # WIFI
There was a problem hiding this comment.
Sounds like this file should go somewhere in ext/ or?
What goes into all directories but ext, is made for zephyr so there is no such thing as redefining stuff like NULL, uints ... etc... that's useless: Zephyr provides all necessary bits and pieces.
There was a problem hiding this comment.
I agree with Tomasz, these changes look like they belong to ext.
There was a problem hiding this comment.
I left the function prototypes in this file and moved the other definitions in ext
There was a problem hiding this comment.
so no camelcase, but change this to:
K_MS(time_msec) * USEC_PER_SEC
USEC_PER_SEC is found in include/sys_clock.h
There was a problem hiding this comment.
no need to re-document how spi is configured as all is in spi.h already
There was a problem hiding this comment.
removed and configured with spi defines
There was a problem hiding this comment.
that does not seem to be the case. You are returning -1 in error.
There was a problem hiding this comment.
I agree with Tomasz, these changes look like they belong to ext.
MaxAgneni
force-pushed
the
net
branch
2 times, most recently
from
4980ace to
834c9f2
Compare
boards/x86/panther/Kconfig.defconfig
Outdated
There was a problem hiding this comment.
Remove this, this board does not use NBLE, NBLE is only being used for Arduino 101 with a custom Bluetooth firmware
boards/x86/panther/Kconfig.defconfig
Outdated
There was a problem hiding this comment.
This part of Kconfig is just removed
ext/drivers/atmel/winc1500/Kconfig
Outdated
There was a problem hiding this comment.
everything is commented out here, so what is the point of adding this file?
There was a problem hiding this comment.
point to add this file is drivers/wifi/winc1500/Kconfig
There was a problem hiding this comment.
but the while thing is commented, so it has no effect at all
There was a problem hiding this comment.
in Makefile there is:
obj-$(CONFIG_WIFI_WINC1500) += ....
nashif
force-pushed
the
net
branch
2 times, most recently
from
60dfcb1 to
203fdd7
Compare
This is part of a patch series to add support for winc1500 wifi module origin: extracted from Atmel ASF version 3.33.0 Signed-off-by: Massimiliano Agneni <[email protected]> Signed-off-by: Anas Nashif <[email protected]> Signed-off-by: Dario Pennisi <[email protected]>
was: https://gerrit.zephyrproject.org/r/#/c/12365/ Signed-off-by: Massimiliano Agneni <[email protected]> Signed-off-by: Anas Nashif <[email protected]> Signed-off-by: Dario Pennisi <[email protected]>
Signed-off-by: Massimiliano Agneni <[email protected]> Signed-off-by: Dario Pennisi <[email protected]> Signed-off-by: Anas Nashif <[email protected]>
was: https://gerrit.zephyrproject.org/r/#/c/12364/ Signed-off-by: Massimiliano Agneni <[email protected]> Signed-off-by: Dario Pennisi <[email protected]> Signed-off-by: Anas Nashif <[email protected]>
was: https://gerrit.zephyrproject.org/r/#/c/12363/ Signed-off-by: Massimiliano Agneni <[email protected]>
|
Is there a general need for the offload ip stack with this driver? The last commit only removes a couple of dependencies, but not all of them. |
|
Taken over by #4711 |
7 participants
This is part of a patch series to add support for winc1500 wifi module
origin: extracted from Atmel ASF version 3.33.0
was: https://gerrit.zephyrproject.org/r/#/c/12356/