tests: bluetooth: tester: Fix ATT max attr size assert #59067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATT attributes can be up to 512 bytes long, so the comparisong needed fixing. See spec v5.4, Vol 3, Part F, 3.2.9. Fixes zephyrproject-rtos#57930. Signed-off-by: Carles Cufi <[email protected]>
carlescufi
requested review from
Vudentz,
alwa-nordic,
jhedberg and
sjanc
as code owners
carlescufi
requested review from
Thalley,
hermabe,
jhedberg,
jori-nordic and
sjanc
and removed request for
Thalley,
Vudentz,
alwa-nordic,
jhedberg and
sjanc
hermabe
approved these changes
Jun 8, 2023
jori-nordic
approved these changes
Jun 8, 2023
jhedberg
approved these changes
Jun 8, 2023
alwa-nordic
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATT attributes can be up to 512 bytes long, so the comparisong needed fixing.
See spec v5.4, Vol 3, Part F, 3.2.9.
Fixes #57930.