rp2040: Fix I2C frequency for all boards #58814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DW driver used by the RP2040 boards uses a Kconfig symbol to determine the clock speed of the board. This value was set incorrectly by the pico board to 100MHz (instead of 125). For the other boards, it wasn't set at all. This commit fixes the kconfig defaults. In the future, this value should be taken directly from the devicetree. This is not currently possible as there is no clock control driver for the RP2040 (see zephyrproject-rtos#52901). Signed-off-by: Yonatan Schachter <[email protected]>
nashif
approved these changes
Jun 5, 2023
soburi
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DW driver used by the RP2040 boards uses a Kconfig symbol to determine the clock speed of the board. This value was set incorrectly by the pico board to 100MHz (instead of 125). For the other boards, it wasn't set at all.
This commit fixes the kconfig defaults. In the future, this value should be taken directly from the devicetree. This is not currently possible as there is no clock control driver for the RP2040 (see #52901).
Fixes #56230